Re: [PATCH v4 03/12] xen/spinlock: introduce new type for recursive spinlocks

From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	xen-devel@lists.xenproject.org
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
	"George Dunlap" <george.dunlap@citrix.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Paul Durrant" <paul@xen.org>
Subject: Re: [PATCH v4 03/12] xen/spinlock: introduce new type for recursive spinlocks
Date: Thu, 21 Dec 2023 12:06:20 +0100	[thread overview]
Message-ID: <14f2857f-5afb-4c04-ab84-6b8403f1dbc8@suse.com> (raw)
In-Reply-To: <36331c0f-d495-4263-95a6-e1c5abcac060@suse.com>

[-- Attachment #1.1.1: Type: text/plain, Size: 1320 bytes --]

On 21.12.23 11:34, Jan Beulich wrote:
> On 12.12.2023 13:57, Julien Grall wrote:
>> On 12/12/2023 09:47, Juergen Gross wrote:
>>> @@ -109,12 +109,16 @@ struct lock_profile_qhead {
>>>        spinlock_t l = _SPIN_LOCK_UNLOCKED(NULL);                                 \
>>>        static struct lock_profile __lock_profile_data_##l = _LOCK_PROFILE(l);    \
>>>        _LOCK_PROFILE_PTR(l)
>>> +#define DEFINE_RSPINLOCK(l)                                                   \
>>> +    rspinlock_t l = _SPIN_LOCK_UNLOCKED(NULL);                                \
>>> +    static struct lock_profile __lock_profile_data_##l = _LOCK_PROFILE(l);    \
>>> +    _LOCK_PROFILE_PTR(l)
>>>    
>>> -#define spin_lock_init_prof(s, l)                                             \
>>> +#define __spin_lock_init_prof(s, l, locktype)                                 \
>>
>> If I am not mistaken the double-underscore prefix is a violation in
>> MISRA. So can this be renamed to:
>>
>> spin_lock_init_prof__()?
> 
> Is the new parameter needed at all? Can't we use typeof((s)->l) in place of
> passing the type explicitly?

IMO spin_lock_init_prof() should be usable for spinlock_t only, and
rspin_lock_init_prof() for rspinlock_t only. Using typeof() would make
either of them usable for both types.

Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]