From: Chris Wilson <chris@chris-wilson.co.uk>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
martin.peres@free.fr, Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 2/3] drm/i915: Fix fbdev unload sequence
Date: Fri, 14 Jul 2017 20:32:18 +0100 [thread overview]
Message-ID: <150006073899.13756.17377796172438978103@mail.alporthouse.com> (raw)
In-Reply-To: <20170714191439.31169-2-daniel.vetter@ffwll.ch>
Quoting Daniel Vetter (2017-07-14 20:14:38)
Second nit:
> +void intel_fbdev_fini(struct drm_i915_private *dev_priv)
> +{
> + struct intel_fbdev *ifbdev = dev_priv->fbdev;
> +
> + if (!ifbdev)
> + return;
> +
> intel_fbdev_destroy(ifbdev);
> dev_priv->fbdev = NULL;
Maybe
struct intel_fbdev *ifbdev;
ifbdev = fetch_and_zero(&dev_priv->fbdev);
if (!fbdev)
return;
intel_fbdev_destroy(ifbdev);
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-07-14 19:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 19:14 [PATCH 1/3] drm/atomic-helper: Fix leak in disable_all Daniel Vetter
2017-07-14 19:14 ` [PATCH 2/3] drm/i915: Fix fbdev unload sequence Daniel Vetter
2017-07-14 19:30 ` Chris Wilson
2017-07-14 19:32 ` Chris Wilson [this message]
2017-07-14 19:14 ` [PATCH 3/3] drm/i915: unregister interfaces first in unload Daniel Vetter
2017-07-14 19:35 ` Chris Wilson
2017-07-14 19:27 ` [PATCH 1/3] drm/atomic-helper: Fix leak in disable_all Chris Wilson
2017-07-14 20:18 ` ✗ Fi.CI.BAT: failure for series starting with [1/3] " Patchwork
2017-07-14 20:32 ` Chris Wilson
2017-07-14 21:03 ` Daniel Vetter
2017-07-14 21:17 ` Chris Wilson
2017-07-14 21:50 ` Daniel Vetter
2017-07-14 22:46 [PATCH 1/3] " Daniel Vetter
2017-07-14 22:46 ` [PATCH 2/3] drm/i915: Fix fbdev unload sequence Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150006073899.13756.17377796172438978103@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=martin.peres@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.