Re: [Qemu-devel] [PULL 00/21] Block layer patches - no-reply

From: no-reply@patchew.org
To: kwolf@redhat.com
Cc: famz@redhat.com, qemu-block@nongnu.org, peter.maydell@linaro.org,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 00/21] Block layer patches
Date: Tue, 18 Jul 2017 14:23:57 -0700 (PDT)	[thread overview]
Message-ID: <150041303653.87.14552021942412556226@5d477a5b5989> (raw)
In-Reply-To: <1500387486-5469-1-git-send-email-kwolf@redhat.com>

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 00/21] Block layer patches
Message-id: 1500387486-5469-1-git-send-email-kwolf@redhat.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
65ef5d7 qemu-img: Check for backing image if specified during create
1ed5939 blockdev: move BDRV_O_NO_BACKING option forward
a881ee1 block/vvfat: Fix compiler warning with gcc 7
313dec5 vvfat: initialize memory after allocating it
e18cf9f vvfat: correctly parse non-ASCII short and long file names
d24fe91 vvfat: add a constant for bootsector name
213812e vvfat: add constants for special values of name[0]
079d39b qemu-iotests: Test unplug of -device without drive
99f1345 qemu-iotests: Test 'info block'
7c33c97 scsi-disk: bdrv_attach_dev() for empty CD-ROM
1529192 ide: bdrv_attach_dev() for empty CD-ROM
48dd434 block: List anonymous device BBs in query-block
9b5bf99 block/qapi: Use blk_all_next() for query-block
90cf4d0 block: Make blk_all_next() public
7034977 block/qapi: Add qdev device name to query-block
012e33e block: Make blk_get_attached_dev_id() public
49e9e06 block/vpc.c: Handle write failures in get_image_offset()
fe47440 block/vmdk: Report failures in vmdk_read_cid()
b7a0797 block: remove timer canceling in throttle_config()
8179adf block: add clock_type field to ThrottleGroup
be86950 commit: Add NULL check for overlay_bs

=== OUTPUT BEGIN ===
Checking PATCH 1/21: commit: Add NULL check for overlay_bs...
Checking PATCH 2/21: block: add clock_type field to ThrottleGroup...
Checking PATCH 3/21: block: remove timer canceling in throttle_config()...
Checking PATCH 4/21: block/vmdk: Report failures in vmdk_read_cid()...
Checking PATCH 5/21: block/vpc.c: Handle write failures in get_image_offset()...
Checking PATCH 6/21: block: Make blk_get_attached_dev_id() public...
Checking PATCH 7/21: block/qapi: Add qdev device name to query-block...
Checking PATCH 8/21: block: Make blk_all_next() public...
Checking PATCH 9/21: block/qapi: Use blk_all_next() for query-block...
Checking PATCH 10/21: block: List anonymous device BBs in query-block...
Checking PATCH 11/21: ide: bdrv_attach_dev() for empty CD-ROM...
Checking PATCH 12/21: scsi-disk: bdrv_attach_dev() for empty CD-ROM...
Checking PATCH 13/21: qemu-iotests: Test 'info block'...
Checking PATCH 14/21: qemu-iotests: Test unplug of -device without drive...
Checking PATCH 15/21: vvfat: add constants for special values of name[0]...
Checking PATCH 16/21: vvfat: add a constant for bootsector name...
Checking PATCH 17/21: vvfat: correctly parse non-ASCII short and long file names...
Checking PATCH 18/21: vvfat: initialize memory after allocating it...
Checking PATCH 19/21: block/vvfat: Fix compiler warning with gcc 7...
Checking PATCH 20/21: blockdev: move BDRV_O_NO_BACKING option forward...
Checking PATCH 21/21: qemu-img: Check for backing image if specified during create...
ERROR: Error messages should not contain newlines
#103: FILE: block.c:4432:
+                            "This may become an error in future versions.\n");

total: 1 errors, 0 warnings, 251 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1

---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org