From: Richard Henderson <richard.henderson@linaro.org>
To: Helge Deller <deller@gmx.de>, qemu-devel@nongnu.org
Cc: svens@stackframe.org
Subject: Re: [PATCH 1/3] target/hppa: Fix assemble_16 insns for wide mode
Date: Mon, 4 Mar 2024 13:58:17 -1000 [thread overview]
Message-ID: <15047e82-6669-4200-9ddb-5118853a001d@linaro.org> (raw)
In-Reply-To: <6f44d208-5ba1-43e4-b6de-8e48f3cc497f@gmx.de>
On 3/2/24 20:43, Helge Deller wrote:
>> +/* Expander for assemble_16(s,im14). */
>> +static int expand_16(DisasContext *ctx, int val)
>> +{
>> + /*
>> + * @val is bits [0:15], containing both im14 and s.
>> + * Swizzle thing around depending on PSW.W.
>> + */
>> + int i = (-(val & 1) << 13) | extract32(val, 1, 13);
>> +
>> + if (ctx->tb_flags & PSW_W) {
>> + i ^= val & (3 << 13);
>
> Patch boots when I change to:
> + i ^= ((val >> 14) & 3) << 13;
>
Whoops, yes.
r~
next prev parent reply other threads:[~2024-03-04 23:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 2:19 [PATCH 0/3] target/hppa: Fix some wide mode displacements Richard Henderson
2024-03-03 2:19 ` [PATCH 1/3] target/hppa: Fix assemble_16 insns for wide mode Richard Henderson
2024-03-03 6:43 ` Helge Deller
2024-03-04 23:58 ` Richard Henderson [this message]
2024-03-03 2:19 ` [PATCH 2/3] target/hppa: Fix assemble_11a " Richard Henderson
2024-03-03 6:52 ` Helge Deller
2024-03-03 6:57 ` Helge Deller
2024-03-04 6:44 ` Richard Henderson
2024-03-03 2:19 ` [PATCH 3/3] target/hppa: Fix assemble_12a " Richard Henderson
2024-03-03 7:11 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15047e82-6669-4200-9ddb-5118853a001d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.