From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Srivatsa, Anusha" <anusha.srivatsa@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "Sundaresan, Sujaritha" <sujaritha.sundaresan@intel.com>
Subject: Re: [PATCH 1/2] drm/i915/guc: Add GuC Load time to debugfs
Date: Fri, 08 Sep 2017 19:04:01 +0100 [thread overview]
Message-ID: <150489384129.23880.13714641921216637676@mail.alporthouse.com> (raw)
In-Reply-To: <83F5C7385F545743AD4FB2A62F75B0732C42C683@ORSMSX108.amr.corp.intel.com>
Quoting Srivatsa, Anusha (2017-09-08 18:58:11)
>
>
> >-----Original Message-----
> >From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> >Sent: Thursday, September 7, 2017 3:08 PM
> >To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>; Srivatsa, Anusha
> ><anusha.srivatsa@intel.com>; intel-gfx@lists.freedesktop.org
> >Cc: Sundaresan, Sujaritha <sujaritha.sundaresan@intel.com>
> >Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Add GuC Load time to debugfs
> >
> >Quoting Tvrtko Ursulin (2017-09-07 09:49:02)
> >>
> >> On 07/09/2017 01:37, Anusha Srivatsa wrote:
> >> > Calculate the time that GuC takes to load.
> >> > This information could be very useful in determining if GuC is
> >> > taking unreasonably long time to load in a certain platforms.
> >>
> >> Do we need this in debugfs or a DRM_NOTE or something would be
> >> sufficient if the load time is above certain threshold?
> >>
> >> Also, what are the typical times here? Are jiffies precise enough?
> >> Could be only 10ms granularity on some kernels.
> >
> >Hear, hear. Aiming for jiffie resolution sets a very low bar.
> >
> >Why is this important anyway? It shouldn't be on the critical path for bringing up
> >userspace (i.e. on the synchronous portion of boot/module loading). Nor should
> >it be delaying bringing up a screen, once the core is initialised we should be able
> >to bring up GT and the display in parallel.
>
> Hi Chris,
> Wont it still be of some value to know the time taken to load the firmware in different platforms? To have some data to tell how much time it takes to load?
If it always reports 0 jiffies that is not much use. Why do you need to
add code to do this since you can just log the function call timings?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-08 18:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 0:37 [PATCH 1/2] drm/i915/guc: Add GuC Load time to debugfs Anusha Srivatsa
2017-09-07 0:37 ` [PATCH 2/2] drm/i915/huc: Add HuC " Anusha Srivatsa
2017-09-07 0:40 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Add GuC " Patchwork
2017-09-07 8:49 ` [PATCH 1/2] " Tvrtko Ursulin
2017-09-07 10:23 ` Michal Wajdeczko
2017-09-07 17:07 ` Srivatsa, Anusha
2017-09-07 17:07 ` Srivatsa, Anusha
2017-09-11 15:53 ` Tvrtko Ursulin
2017-09-07 22:08 ` Chris Wilson
2017-09-08 17:58 ` Srivatsa, Anusha
2017-09-08 18:04 ` Chris Wilson [this message]
2017-09-08 7:17 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150489384129.23880.13714641921216637676@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=anusha.srivatsa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sujaritha.sundaresan@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.