From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/8] lib/igt_dummyload: add igt_cork
Date: Fri, 13 Oct 2017 09:31:56 +0100 [thread overview]
Message-ID: <150788351696.17631.13526240235137941879@mail.alporthouse.com> (raw)
In-Reply-To: <150784905844.10704.18344702853864996126@mail.alporthouse.com>
Quoting Chris Wilson (2017-10-12 23:57:38)
> Quoting Daniele Ceraolo Spurio (2017-10-12 23:27:27)
> > +igt_cork_t *igt_cork_new(int fd);
>
> _new does not imply plugged.
>
> > +void igt_cork_signal(igt_cork_t *cork);
>
> When have you signaled a cork?
>
> > +void igt_cork_free(int fd, igt_cork_t *cork);
>
> _free does not imply unplug.
To be clear the verbs are to plug and unplug a queue/schedule. Cork is a
reference to TCP_CORK which does the same thing, but plug/unplug are
more commonplace (at least in kernel code).
I don't see any reason why we need a malloc here.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-13 8:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 22:27 [PATCH i-g-t 0/8] extract cork and ring measure code Daniele Ceraolo Spurio
2017-10-12 22:27 ` [PATCH i-g-t 1/8] lib/igt_dummyload: add igt_cork Daniele Ceraolo Spurio
2017-10-12 22:48 ` Chris Wilson
2017-10-12 22:55 ` Chris Wilson
2017-10-12 22:57 ` Chris Wilson
2017-10-13 8:31 ` Chris Wilson [this message]
2017-10-13 16:37 ` Daniele Ceraolo Spurio
2017-10-18 15:49 ` Daniele Ceraolo Spurio
2017-10-18 16:04 ` Chris Wilson
2017-10-18 16:50 ` Daniele Ceraolo Spurio
2017-10-19 18:12 ` Chris Wilson
2017-10-19 20:15 ` Daniele Ceraolo Spurio
2017-10-12 22:27 ` [PATCH i-g-t 2/8] lib/igt_gt: add intel_measure_ring_size Daniele Ceraolo Spurio
2017-10-12 22:27 ` [PATCH i-g-t 3/8] tests/gem_exec_schedule: use new common functions Daniele Ceraolo Spurio
2017-10-12 22:27 ` [PATCH i-g-t 4/8] tests/gem_exec_fence: " Daniele Ceraolo Spurio
2017-10-12 22:27 ` [PATCH i-g-t 5/8] tests/gem_exec_latency: " Daniele Ceraolo Spurio
2017-10-12 22:27 ` [PATCH i-g-t 6/8] tests/gem_wait: use igt_cork Daniele Ceraolo Spurio
2017-10-12 22:27 ` [PATCH i-g-t 7/8] tests/gem_exec_await: use intel_measure_ring_size Daniele Ceraolo Spurio
2017-10-12 22:27 ` [PATCH i-g-t 8/8] tests/gem_ringfill: " Daniele Ceraolo Spurio
2017-10-12 22:48 ` ✓ Fi.CI.BAT: success for extract cork and ring measure code Patchwork
2017-10-12 23:12 ` [PATCH i-g-t 0/8] " Chris Wilson
2017-10-13 5:32 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150788351696.17631.13526240235137941879@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=daniele.ceraolospurio@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.