Re: [PATCH 4/8] ASoC: Intel: move all ACPI match tables to common module

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	alsa-devel@alsa-project.org
Cc: tiwai@suse.de, vinod.koul@intel.com, broonie@kernel.org,
	liam.r.girdwood@linux.intel.com
Subject: Re: [PATCH 4/8] ASoC: Intel: move all ACPI match tables to common module
Date: Fri, 13 Oct 2017 19:38:46 +0300	[thread overview]
Message-ID: <1507912726.16112.466.camel@linux.intel.com> (raw)
In-Reply-To: <20171012234945.30318-5-pierre-louis.bossart@linux.intel.com>

On Thu, 2017-10-12 at 18:49 -0500, Pierre-Louis Bossart wrote:
> First step of cleaning, move all tables to soc-acpi-intel-match
> module.
> The tables remain in separate files per platform to keep them
> manageable. Skylake+ platforms are still handled elsewhere since
> there is no conflict with SOF for now, but this will have to be
> handled at a later point.

> +static int is_byt(void)
> +{
> +	bool status = false;
> +	static const struct x86_cpu_id cpu_ids[] = {
> +		{ X86_VENDOR_INTEL, 6, 55 }, /* Valleyview, Bay Trail
> */
> +		{}
> +	};
> +	if (x86_match_cpu(cpu_ids))
> +		status = true;
> +	return status;
> +}

I wish it would be cleaned up at some point...

P.S. Yes, I have commented on this earlier.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy