From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Vivek Goyal <vgoyal@redhat.com>,
linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 0/3] Overlayfs orphan index cleanup tests
Date: Tue, 28 Nov 2017 18:41:59 +0200 [thread overview]
Message-ID: <1511887322-29254-1-git-send-email-amir73il@gmail.com> (raw)
Eryu,
Vivek found a bug with the index nlink accounting of the index feature
that was introduced in kernel v4.13.
The bug was there from the first implementation of index and the
tests I wrote to verify nlink accounting (overlay/033,034) did not
cover the bug use case.
The first regression test (overlay/047) demonstrates the effects
of the bug on end user.
The second regression test (overlay/048) adds the missing test coverage
of the existing nlink accounting tests.
The kernel bug was hiding a bug in test overlay/042, so Vivek's
kernel fix broke the test. The last patch fixes the wrong/broken test.
Amir.
Amir Goldstein (3):
overlay: regression test for hardlink breakage after unlink and mount
overlay: regression test for orphan index cleanup on mount
overlay/042: remove wrong check for empty index
tests/overlay/042 | 4 --
tests/overlay/047 | 107 ++++++++++++++++++++++++++++++++++++++
tests/overlay/047.out | 16 ++++++
tests/overlay/048 | 141 ++++++++++++++++++++++++++++++++++++++++++++++++++
tests/overlay/048.out | 18 +++++++
tests/overlay/group | 2 +
6 files changed, 284 insertions(+), 4 deletions(-)
create mode 100755 tests/overlay/047
create mode 100644 tests/overlay/047.out
create mode 100755 tests/overlay/048
create mode 100644 tests/overlay/048.out
--
2.7.4
next reply other threads:[~2017-11-28 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 16:41 Amir Goldstein [this message]
2017-11-28 16:42 ` [PATCH 1/3] overlay: regression test for hardlink breakage after unlink and mount cycle Amir Goldstein
2017-11-28 16:42 ` [PATCH 2/3] overlay: regression test for orphan index cleanup on mount Amir Goldstein
2017-11-28 16:42 ` [PATCH 3/3] overlay/042: remove wrong check for empty index Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511887322-29254-1-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.