Re: [PATCH v3 0/3] ACPI, ASoC, gpio: Add and use acpi_dev_get_first_match_name()

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Erik Schmauss <erik.schmauss@intel.com>,
	linux-acpi@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	alsa-devel@alsa-project.org,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v3 0/3] ACPI, ASoC, gpio: Add and use acpi_dev_get_first_match_name()
Date: Fri, 05 Jan 2018 19:08:41 +0200	[thread overview]
Message-ID: <1515172121.7000.749.camel@linux.intel.com> (raw)
In-Reply-To: <6614de84-5d58-fa01-5247-717af2e6c1b1@linux.intel.com>

On Fri, 2018-01-05 at 10:13 -0600, Pierre-Louis Bossart wrote:
> On 1/5/18 10:09 AM, Andy Shevchenko wrote:
> > It appears that at least one current user (patch 3) and upcoming one
> > (patch 2) need to get device name by ACPI HID.
> > 
> > Here we introduce acpi_dev_get_first_match_name() based on code
> > done for acpi_dev_present() and reuse it where appropriate.
> > 
> > The series has been tested on Intel Edison with non-ACPI and
> > ACPI enabled versions of U-Boot, while patches 1 and 3 were tested
> > by Pierre.
> > 
> > Since patch 1 and cross subsystem nature of the series I think
> > the best way is to push this (patches 1 and 2) via Rafael's linux-pm 
> > tree.
> > 
> > Taking into consideration that patch 3 requires not-yet-applied work
> > from Pierre, I left it for reference, in particular to show the LOC
> > statistics.
> > 
> > Changelog v3:
> > - add Pierre's tag (I dared to do this for both patches 1 and 3)
> 
> I tested a modified version of patch 3 (conflict resolution +
> addition 
> of ES8316 support).

In v3 these have been addressed as I put above as "requires non-yet-
applied work".

> 
> > - address comment about function name (patch 1)
> > - add a reference to the first user (patch 1)
> > - consolidate pin control device possible names in one place (patch
> > 2)
> > - rebase ASoC patch on not-yet-applied series from Pierre (patch 3),
> > and
> > - thus reordered to make it last in the series (patch 3)
> > 
> > Andy Shevchenko (3):
> >    ACPI / utils: Introduce acpi_dev_get_first_match_name()
> >    gpio: merrifield: Add support of ACPI enabled platforms
> >    ASoC: Intel - Convert to use acpi_dev_get_first_match_name()
> > 
> >   drivers/acpi/utils.c                    | 41
> > +++++++++++++++++++++++++++------
> >   drivers/gpio/gpio-merrifield.c          | 11 ++++++++-
> >   include/acpi/acpi_bus.h                 |  3 +++
> >   include/linux/acpi.h                    |  6 +++++
> >   include/sound/soc-acpi.h                |  7 ------
> >   sound/soc/intel/boards/bytcht_da7213.c  |  2 +-
> >   sound/soc/intel/boards/bytcht_es8316.c  |  2 +-
> >   sound/soc/intel/boards/bytcr_rt5640.c   |  2 +-
> >   sound/soc/intel/boards/bytcr_rt5651.c   |  2 +-
> >   sound/soc/intel/boards/cht_bsw_rt5645.c |  2 +-
> >   sound/soc/intel/boards/cht_bsw_rt5672.c |  2 +-
> >   sound/soc/soc-acpi.c                    | 33 -------------------
> > -------
> >   12 files changed, 59 insertions(+), 54 deletions(-)
> > 
> 
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy