Re: [RFC] drm/atomic: Abuse legacy cursor update flag for legacy gamma update too

From: Chris Wilson <chris@chris-wilson.co.uk>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [RFC] drm/atomic: Abuse legacy cursor update flag for legacy gamma update too
Date: Tue, 13 Feb 2018 09:16:16 +0000	[thread overview]
Message-ID: <151851337660.8633.5850364316863092338@mail.alporthouse.com> (raw)
In-Reply-To: <20180213091201.12776-1-maarten.lankhorst@linux.intel.com>

Quoting Maarten Lankhorst (2018-02-13 09:12:01)
> Programs like redshift set the legacy gamma for X.org every 5 seconds.
> Because atomic commits wait for vblank completion, we get a frame drop
> every 5 seconds because of the legacy gamma update.
> 
> Work around this by setting the legacy_cursor_update flag, to force
> legacy gamma updates not to be synced against vblank.
> 
> Reported-by: Tholin #intel-gfx
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Reminiscing: Remember the time we had all those vblank workers patches,
one of which was to do async gamma updates (apply the last one on the
vblank). Motivated by gnome-shell and the ilk doing a gamma animation
for fade-out on logout (which I guess they gave up on since it happened
to be so slow as to extend logout ;).
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel