From: Dave Jiang <dave.jiang@intel.com>
To: vishal.l.verma@intel.com, dan.j.williams@intel.com
Cc: linux-nvdimm@lists.01.org
Subject: [PATCH v6] ndctl: add option to list firmware information for a DIMM
Date: Tue, 20 Feb 2018 11:18:22 -0700 [thread overview]
Message-ID: <151915058813.67767.11669588596758645038.stgit@djiang5-desk3.ch.intel.com> (raw)
Adding firmware output of firmware information when ndctl list -D -F is used.
Components displayed are current firmware version, updated firmware version,
and if a coldboot is required (firmware updated).
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Tested-by: Jeff Moyer <jmoyer@redhat.com>
---
v6:
- changed all instaces of API calls of updated_version to next_version for
better clarity. Data structure for Intel DSM not changed.
- changed coldboot_required to need_powercycle for better clarity.
v5:
- Changed next_version to updated version to be in sync with DSM spec.
- Changed emission of "unknown" string to -1 for error versions.
v4:
- Remove output when updated_version is 0. That indicates no updated firmware.
v3:
- Fixed issue where it skips displaying rest of the details if there's no
firmware details.
v2:
- Added copyright
- Added support for human readable option (hex) for versions
- Removed check against CMD_CALL as it's not useful
---
Dave Jiang (1):
ndctl: add option to list firmware information for a DIMM
Documentation/ndctl/ndctl-list.txt | 13 +++++
ndctl/Makefile.am | 1
ndctl/lib/firmware.c | 2 -
ndctl/lib/intel.c | 12 ++++-
ndctl/lib/libndctl.sym | 2 -
ndctl/lib/private.h | 2 -
ndctl/libndctl.h | 2 -
ndctl/list.c | 13 +++++
ndctl/util/json-firmware.c | 91 ++++++++++++++++++++++++++++++++++++
util/json.h | 2 +
10 files changed, 134 insertions(+), 6 deletions(-)
create mode 100644 ndctl/util/json-firmware.c
--
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next reply other threads:[~2018-02-20 18:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 18:18 Dave Jiang [this message]
2018-02-20 18:18 ` [PATCH v6] ndctl: add option to list firmware information for a DIMM Dave Jiang
2018-02-20 19:51 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151915058813.67767.11669588596758645038.stgit@djiang5-desk3.ch.intel.com \
--to=dave.jiang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.