From: Johannes Berg <johannes@sipsolutions.net>
To: Hauke Mehrtens <hauke@hauke-m.de>, backports@vger.kernel.org
Subject: Re: [PATCH 03/14] patches: Use old parameter type for DEFINE_TIMER
Date: Wed, 21 Mar 2018 08:59:25 +0100 [thread overview]
Message-ID: <1521619165.2645.11.camel@sipsolutions.net> (raw)
In-Reply-To: <20180304225717.20890-4-hauke@hauke-m.de>
On Sun, 2018-03-04 at 23:57 +0100, Hauke Mehrtens wrote:
> Use the unsigned long parameters on kernel versions < 4.15 for the
> DEFINE_TIMER callback. This was changed in Linux mainline commit
> 24ed960abf1d ("treewide: Switch DEFINE_TIMER callbacks to struct
> timer_list *")
But before this, we had a macro that could deal with both ways - why
can't we backport using a similar macro, rather than doing a patch?
If we have
static void at76_ledtrig_tx_timerfunc(struct timer_list *unused);
then we should be able to
#define DEFINE_TIMER(x, y) ... (cast)(y)
or something, no?
johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in
next prev parent reply other threads:[~2018-03-21 7:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 22:57 [PATCH 00/14] backports: multiple fixes and Realtek drivers Hauke Mehrtens
2018-03-04 22:57 ` [PATCH 01/14] patches: refresh on kernel v4.16-rc3 Hauke Mehrtens
2018-03-04 22:57 ` [PATCH 02/14] compat: timer.h: Remove last parameters from DEFINE_TIMER Hauke Mehrtens
2018-03-04 22:57 ` [PATCH 03/14] patches: Use old parameter type for DEFINE_TIMER Hauke Mehrtens
2018-03-21 7:59 ` Johannes Berg [this message]
2018-03-04 22:57 ` [PATCH 04/14] backport: poll.h: add include linux/eventpoll.h Hauke Mehrtens
2018-03-04 22:57 ` [PATCH 05/14] header: types.h: add __poll_t Hauke Mehrtens
2018-03-04 22:57 ` [PATCH 06/14] header: kernel.h: include bug.h Hauke Mehrtens
2018-03-04 22:57 ` [PATCH 07/14] header: debugfs.h: add DEFINE_DEBUGFS_ATTRIBUTE Hauke Mehrtens
2018-03-04 22:57 ` [PATCH 08/14] header: nospec.h: provide dummy header file Hauke Mehrtens
2018-03-04 22:57 ` [PATCH 09/14] header: timekeeping.h: Add ktime_get_real_seconds() Hauke Mehrtens
2018-03-04 22:57 ` [PATCH 10/14] header: timekeeping.h: Add ktime_get_ts64() Hauke Mehrtens
2018-03-04 22:57 ` [PATCH 11/14] header: netdevice.h: Fix netdev_upper_dev_link on 4.14 Hauke Mehrtens
2018-03-04 22:57 ` [PATCH 12/14] header: inet_frag.h: Use old version of in sub_frag_mem_limit() for kernel 3.16 Hauke Mehrtens
2018-03-04 22:57 ` [PATCH 13/14] dependencies: Make mt76 depend on kernel 4.1 Hauke Mehrtens
2018-03-04 22:57 ` [PATCH 14/14] backports: Add staging rtlwifi, rtl8188eu and rtl8723bs driver Hauke Mehrtens
2018-03-21 8:20 ` [PATCH 00/14] backports: multiple fixes and Realtek drivers Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521619165.2645.11.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=backports@vger.kernel.org \
--cc=hauke@hauke-m.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.