Re: [PATCH 02/11] drm/i915/execlists: Clear user-active flag on preemption completion

From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 02/11] drm/i915/execlists: Clear user-active flag on preemption completion
Date: Tue, 27 Mar 2018 11:00:32 +0100	[thread overview]
Message-ID: <152214483229.10679.18186499340673234228@mail.alporthouse.com> (raw)
In-Reply-To: <20180326115044.2505-3-chris@chris-wilson.co.uk>

Quoting Chris Wilson (2018-03-26 12:50:35)
> When cancelling the requests and clearing out the ports following a
> successful preemption completion, also clear the active flag. I had
> assumed that all preemptions would be followed by an immediate dequeue
> (preserving the active user flag), but under rare circumstances we may
> be triggering a preemption for the second port only for it to have
> completed before the preemotion kicks in; leaving execlists->active set
> even though the system is now idle.
> 
> We can clear the flag inside the common execlists_cancel_port_requests()
> as the other users also expect the semantics of active being cleared.
> 
> Fixes: f6322eddaff7 ("drm/i915/preemption: Allow preemption between submission ports")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Michał Winiarski <michal.winiarski@intel.com>
> Cc: Michel Thierry <michel.thierry@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

From the earlier posting,
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Mika, any chance you want to complete the hat check and review the first
patch as well? :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx