Re: ✗ Fi.CI.IGT: failure for series starting with [v6,01/12] drm/i915: Correctly handle error path in i915_gem_init_hw

From: Chris Wilson <chris@chris-wilson.co.uk>
To: Sagar Arun Kamble <sagar.a.kamble@intel.com>,
	intel-gfx@lists.freedesktop.org,
	Patchwork <patchwork@emeril.freedesktop.org>,
	Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: Re: ✗ Fi.CI.IGT: failure for series starting with [v6,01/12] drm/i915: Correctly handle error path in i915_gem_init_hw
Date: Thu, 05 Apr 2018 11:19:16 +0100	[thread overview]
Message-ID: <152292355666.23264.15214282430439047023@mail.alporthouse.com> (raw)
In-Reply-To: <bb558b2c-659b-dfbf-4287-d842032a59f4@intel.com>

Quoting Sagar Arun Kamble (2018-04-05 11:02:33)
> 
> 
> On 4/5/2018 6:03 AM, Patchwork wrote:
> > == Series Details ==
> >
> > Series: series starting with [v6,01/12] drm/i915: Correctly handle error path in i915_gem_init_hw
> > URL   : https://patchwork.freedesktop.org/series/41159/
> > State : failure
> >
> > == Summary ==
> >
> > ---- Possible new issues:
> >
> > Test gem_eio:
> >          Subgroup execbuf:
> >                  pass       -> INCOMPLETE (shard-apl)
> I am seeing this failure w/o this patch series too.
> Working fix  that I have tried is to unpark from reset path explicitly 
> if GT is awake:
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c 
> b/drivers/gpu/drm/i915/i915_drv.c
> index d354627..2fc9d0e 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1960,6 +1960,9 @@ void i915_reset(struct drm_i915_private *i915)
>                  goto error;
>          }
> 
> +       if (i915->gt.awake)
> +               intel_engines_unpark(i915);
> +
>          i915_queue_hangcheck(i915);
> 
>   finish:
> 
> This way we will balance the irq refcounts.

Only for them to be unbalanced on resume... Just we don't currently warn
about that.

But that's the kind of plan I have, before we call
reset_default_submission in unwedge, to bludgeon through the full idle
sequence. Just means playing about with the idle worker to extract what
we need from under the mutex, probably calling it i915_gem_park in the
process.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx