From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"Jiang, Dave" <dave.jiang@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH v5 2/4] ndctl: convert namespace actions to use util_filter_walk()
Date: Wed, 9 May 2018 22:47:02 +0000 [thread overview]
Message-ID: <1525906020.4429.1.camel@intel.com> (raw)
In-Reply-To: <152486690348.66587.15082403237213429099.stgit@djiang5-desk3.ch.intel.com>
On Fri, 2018-04-27 at 15:08 -0700, Dave Jiang wrote:
> util_filter_walk() does the looping through of busses and regions.
> Removing
> duplicate code in namespace ops and provide filter functions so we can
> utilize util_filter_walk() and share common code.
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
> ndctl/namespace.c | 163 ++++++++++++++++++++++++++++++-----------------
> ------
> test/btt-check.sh | 2 -
> util/filter.c | 5 +-
> util/filter.h | 8 +++
> 4 files changed, 104 insertions(+), 74 deletions(-)
>
[...]
>
> diff --git a/test/btt-check.sh b/test/btt-check.sh
> index 353d4375..50c1b592 100755
> --- a/test/btt-check.sh
> +++ b/test/btt-check.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash -E
> +#!/bin/bash -Ex
Did you mean to add this hunk?
>
> # Copyright(c) 2015-2017 Intel Corporation. All rights reserved.
> #
> diff --git a/util/filter.c b/util/filter.c
> index 0d3cc02f..b7a4fbd6 100644
> --- a/util/filter.c
> +++ b/util/filter.c
>
[...]
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-05-09 22:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 22:08 [PATCH v5 0/4] ndctl: convert actions to use util_filter_walk Dave Jiang
2018-04-27 22:08 ` [PATCH v5 1/4] ndctl: convert namespace actions to use util_filter_params Dave Jiang
2018-04-27 22:08 ` [PATCH v5 2/4] ndctl: convert namespace actions to use util_filter_walk() Dave Jiang
2018-05-09 22:47 ` Verma, Vishal L [this message]
2018-05-09 22:49 ` Dave Jiang
2018-04-27 22:08 ` [PATCH v5 3/4] ndctl: convert region " Dave Jiang
2018-05-09 23:17 ` Verma, Vishal L
2018-05-09 23:23 ` Dan Williams
2018-05-09 23:24 ` Dave Jiang
2018-05-09 23:26 ` Dan Williams
2018-05-09 23:41 ` Verma, Vishal L
2018-05-11 19:52 ` Dave Jiang
2018-05-11 20:17 ` Dan Williams
2018-04-27 22:08 ` [PATCH v5 4/4] ndctl: convert dimm " Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525906020.4429.1.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.