From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: guaneryu@gmail.com
Cc: darrick.wong@oracle.com, fstests@vger.kernel.org,
Xiao Yang <yangx.jy@cn.fujitsu.com>
Subject: [PATCH v3] generic/486: Get rid of the redundant error=%d printing
Date: Thu, 17 May 2018 11:32:27 +0800 [thread overview]
Message-ID: <1526527947-4905-1-git-send-email-yangx.jy@cn.fujitsu.com> (raw)
In-Reply-To: <20180517031645.GE29080@desktop.hz.ali.com>
1) Without the fix, perror() can indicate the actual error(ENODATA).
2) After calling perror() and redirecting the output of perror()
to a file, errno seems to be set to EINVAL unexpectedly.
See the following mail for detailed info:
https://www.spinics.net/lists/fstests/msg09675.html
Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
src/attr_replace_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/attr_replace_test.c b/src/attr_replace_test.c
index 23adc07..0720bfd 100644
--- a/src/attr_replace_test.c
+++ b/src/attr_replace_test.c
@@ -11,7 +11,7 @@
#include <sys/stat.h>
#define die() do { perror(""); \
-fprintf(stderr, "error=%d at line %d\n", errno, __LINE__); \
+fprintf(stderr, "error at line %d\n", __LINE__); \
exit(1); } while (0)
#define fail(...) do { \
--
1.8.3.1
next prev parent reply other threads:[~2018-05-17 3:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 8:00 [PATCH] generic/486: print correct errno Xiao Yang
2018-05-16 15:27 ` Darrick J. Wong
2018-05-17 1:36 ` [PATCH] generic/486: Get rid of the redundant error=%d printing Xiao Yang
2018-05-17 3:16 ` Eryu Guan
2018-05-17 3:25 ` Xiao Yang
2018-05-17 3:32 ` Xiao Yang [this message]
2018-05-17 14:55 ` [PATCH v3] " Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526527947-4905-1-git-send-email-yangx.jy@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.