From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 02/12] drm/i915: Populate possible_crtcs for primary/cursor planes
Date: Fri, 01 Jun 2018 21:30:58 +0100 [thread overview]
Message-ID: <152788505850.24921.10992442285964149948@mail.alporthouse.com> (raw)
In-Reply-To: <20180601170034.13095-3-ville.syrjala@linux.intel.com>
Quoting Ville Syrjala (2018-06-01 18:00:24)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We're currently not providing the possible_crtcs mask to
> drm_universal_plane_init() for primary/cursor planes. While that does
> work on account of drm_crtc_init_with_planes() filling those up
> for us, it's inconsisten with what we're doing for sprite planes.
>
> Let's just always pass the possible_crtcs bitmask to
> drm_universal_plane_init(). This does assume that crtc->index
> == pipe. But we're already making that assumption elsewhere so
> it doesn't seem like a very big sin here.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
The remaining 3,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-06-01 20:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 17:00 [PATCH v3 00/12] drm/i915: Some plane init cleanups Ville Syrjala
2018-06-01 17:00 ` [PATCH v3 01/12] drm/i915: Constify all plane_funcs structs Ville Syrjala
2018-06-13 12:30 ` Jani Nikula
2018-06-01 17:00 ` [PATCH v3 02/12] drm/i915: Populate possible_crtcs for primary/cursor planes Ville Syrjala
2018-06-01 20:30 ` Chris Wilson [this message]
2018-06-01 20:32 ` Chris Wilson
2018-06-01 17:00 ` [PATCH v3 03/12] drm/i915: Don't populate plane->i9xx_plane for sprites Ville Syrjala
2018-06-01 17:00 ` [PATCH v3 04/12] drm/i915: Allow horizontal mirroring for cnl+ "sprite" planes Ville Syrjala
2018-06-01 17:00 ` [PATCH v3 05/12] drm/i915: Disallow plane scaling with specific pixel formats Ville Syrjala
2018-06-01 17:00 ` [PATCH v3 06/12] drm/i915: Add missing pixel formats for skl+ "sprites" Ville Syrjala
2018-06-01 17:00 ` [PATCH v3 07/12] drm/i915: Move plane_state->scaler_id initialization into intel_create_plane_state() Ville Syrjala
2018-06-01 20:36 ` Chris Wilson
2018-06-01 17:00 ` [PATCH v3 08/12] drm/i915: Introduce intel_plane_alloc() Ville Syrjala
2018-06-01 20:40 ` Chris Wilson
2018-06-01 17:00 ` [PATCH v3 09/12] drm/i915: Extract skl_universal_plane_init() Ville Syrjala
2018-06-01 18:39 ` [PATCH v4 " Ville Syrjala
2018-07-06 11:20 ` Lisovskiy, Stanislav
2018-06-01 17:00 ` [PATCH v3 10/12] drm/i915: Simplify skl_plane_has_planar() Ville Syrjala
2018-06-01 17:00 ` [PATCH v3 11/12] drm/i915: s/intel_plane/plane/ in sprite init Ville Syrjala
2018-06-01 17:00 ` [PATCH v3 12/12] drm/i915: Rename variables in intel_primary_plane_create() Ville Syrjala
2018-06-01 18:39 ` [PATCH v4 " Ville Syrjala
2018-08-29 1:19 ` [PATCH v3 " Dhinakaran Pandiyan
2018-08-29 11:55 ` Ville Syrjälä
2018-06-01 17:07 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Some plane init cleanups Patchwork
2018-06-01 17:26 ` ✓ Fi.CI.BAT: success " Patchwork
2018-06-01 18:59 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Some plane init cleanups (rev3) Patchwork
2018-06-01 19:18 ` ✓ Fi.CI.BAT: success " Patchwork
2018-06-01 19:37 ` ✓ Fi.CI.IGT: success for drm/i915: Some plane init cleanups Patchwork
2018-06-01 20:21 ` ✓ Fi.CI.IGT: success for drm/i915: Some plane init cleanups (rev3) Patchwork
2018-07-06 12:21 ` [PATCH v3 00/12] drm/i915: Some plane init cleanups Lisovskiy, Stanislav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152788505850.24921.10992442285964149948@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.