From: Oliver Neukum <oneukum@suse.com>
To: Patong Yang <patong.mxl@gmail.com>, linux-usb@vger.kernel.org
Cc: johan@kernel.org, gregkh@linuxfoundation.org, pyang@maxlinear.com
Subject: Driver for MaxLinear/Exar USB (UART) Serial Adapters
Date: Wed, 25 Jul 2018 09:38:55 +0200 [thread overview]
Message-ID: <1532504335.6342.0.camel@suse.com> (raw)
On Di, 2018-07-24 at 15:36 -0700, Patong Yang wrote:
> +static int xrusb_ctrl_msg(struct xrusb *xrusb,
> + int request, int value, void *buf, int len)
> +{
> + int rv = usb_control_msg(xrusb->dev,
> + usb_sndctrlpipe(xrusb->dev, 0),
> + request,
> + USB_RT_XRUSB,
> + value,
> + xrusb->control->altsetting[0].desc.bInterfaceNumber,
> + buf,
> + len,
> + 5000);
Please use the symbolic constant.
> + return rv < 0 ? rv : 0;
> +}
Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-07-25 7:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 7:38 Oliver Neukum [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-16 10:05 Driver for MaxLinear/Exar USB (UART) Serial Adapters Greg Kroah-Hartman
2018-08-16 8:28 Patong Yang
2018-08-16 8:26 Oliver Neukum
2018-08-16 6:34 Greg Kroah-Hartman
2018-08-16 5:56 Patong Yang
2018-07-26 10:57 Greg Kroah-Hartman
2018-07-24 22:36 Patong Yang
2018-04-06 14:45 Driver for MaxLinear/Exar USB (UART) Serial adapters Greg Kroah-Hartman
2018-04-05 7:38 Oliver Neukum
2018-04-05 6:26 Greg Kroah-Hartman
2018-04-04 8:00 Greg Kroah-Hartman
2018-04-04 7:59 Greg Kroah-Hartman
2018-04-04 7:38 Oliver Neukum
2018-04-04 7:06 Patong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532504335.6342.0.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=patong.mxl@gmail.com \
--cc=pyang@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.