From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/i915/execlists: Use coherent writes into the context image
Date: Fri, 14 Sep 2018 14:16:12 +0100 [thread overview]
Message-ID: <153693097198.4114.13742793742769508199@skylake-alporthouse-com> (raw)
In-Reply-To: <20180914130335.GB5565@intel.com>
Quoting Ville Syrjälä (2018-09-14 14:03:35)
> On Fri, Sep 14, 2018 at 10:42:15AM +0100, Chris Wilson wrote:
> > That we use a WB mapping for updating the RING_TAIL register inside the
> > context image even on !llc machines has been a source of consternation
> > for every reader. It appears to work on bsw+, but it may just have been
> > that we have been incredibly bad at detecting the errors.
>
> Presumably it's due to the "all ggtt accesses go through pat[0]" and
> we make pat[0] snoop. So presumably the hw should snoop when loading
> the context... maybe.
Shows how much attention I pay, I thought we made pat[0] uncached. Seems
strange to suggest that we should always be snooping when reading GGTT
from the GPU.
We still have the same PTE bits for GGTT as for ppGTT, do we not?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-09-14 13:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 9:42 [PATCH 1/4] drm/i915/execlists: Delay updating ring register state after resume Chris Wilson
2018-09-14 9:42 ` [PATCH 2/4] drm/i915: Park the GPU on module load Chris Wilson
2018-09-14 9:42 ` [PATCH 3/4] drm/i915: Check engine->default_state mapping " Chris Wilson
2018-09-14 11:02 ` Tvrtko Ursulin
2018-09-14 9:42 ` [PATCH 4/4] drm/i915/execlists: Use coherent writes into the context image Chris Wilson
2018-09-14 13:03 ` Ville Syrjälä
2018-09-14 13:16 ` Chris Wilson [this message]
2018-09-14 13:39 ` Ville Syrjälä
2018-09-14 12:29 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915/execlists: Delay updating ring register state after resume Patchwork
2018-09-14 12:47 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153693097198.4114.13742793742769508199@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.