From: Taras Kondratiuk <takondra@cisco.com>
To: Paul Moore <paul@paul-moore.com>, Stephen Smalley <sds@tycho.nsa.gov>
Cc: linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov,
xe-linux-external@cisco.com
Subject: Re: [RFC PATCH] selinux: add a fallback to defcontext for native labeling
Date: Tue, 25 Sep 2018 12:10:56 -0700 [thread overview]
Message-ID: <153790265614.6091.7582646556934797699@takondra-t460s> (raw)
In-Reply-To: <a185b384-5ef1-5e53-2cc1-066391424dcb@tycho.nsa.gov>
Quoting Stephen Smalley (2018-09-25 09:39:55)
> On 09/25/2018 12:03 PM, Paul Moore wrote:
> > On Tue, Sep 25, 2018 at 9:58 AM Stephen Smalley <sds@tycho.nsa.gov> wrote:
<snip>
> >> I'm inclined to just change the behavior for defcontext= unconditionally
> >> and have it apply to both native and xattr labeling. If that's a no-go,
> >> then the simplest solution is to just leave defcontext= behavior
> >> unchanged for xattr labeling and only implement the new semantics for
> >> native labeling. That's just a matter of adding a flag to
> >> security_context_to_sid_default() and only setting it when calling from
> >> selinux_inode_notifysecctx().
> >
> > Neither option is very appealing to me, but that doesn't mean I'm saying "no".
> >
> > From a sanity and consistency point of view I think option #1 (change
> > the defcontext behavior) is a better choice, and I tend to favor this
> > consistency even with the understanding that it could result in some
> > unexpected behavior for users. However, if we get complaints, I'm
> > going to revert this without a second thought.
>
> In that case, I'd suggest splitting it into two patches; first one only
> enables the new behavior for native labeling filesystems (as per the
> above, via a flag to security_context_to_sid_default), and the second
> patch drops the flag and does it unconditionally. Then you can always
> revert the latter without affecting the former.
>
> >
> > So to answer your question Taras, go ahead and prepare a patch so we
> > can take a look. A bit of fair warning that it might get delayed
> > until after the upcoming merge window since we are already at -rc5; I
> > want this to have plenty of time in -next.
> >
> > Thanks guys.
Thanks. I'll prepare patches is a few days.
next prev parent reply other threads:[~2018-09-25 19:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 16:52 [RFC PATCH] selinux: add a fallback to defcontext for native labeling Taras Kondratiuk
2018-09-19 18:47 ` Paul Moore
2018-09-19 19:00 ` Stephen Smalley
2018-09-20 2:41 ` Taras Kondratiuk
2018-09-20 14:49 ` Stephen Smalley
2018-09-20 22:59 ` Taras Kondratiuk
2018-09-21 14:40 ` Stephen Smalley
2018-09-24 21:17 ` Taras Kondratiuk
2018-09-25 3:46 ` Paul Moore
2018-09-25 5:45 ` Taras Kondratiuk
2018-09-25 14:00 ` Stephen Smalley
2018-09-25 16:03 ` Paul Moore
2018-09-25 16:03 ` Paul Moore
2018-09-25 16:39 ` Stephen Smalley
2018-09-25 19:10 ` Taras Kondratiuk [this message]
2018-10-02 18:48 ` Taras Kondratiuk
2018-10-02 19:41 ` Stephen Smalley
2018-10-03 0:58 ` Taras Kondratiuk
2018-09-25 15:41 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153790265614.6091.7582646556934797699@takondra-t460s \
--to=takondra@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.