From: NeilBrown <neilb@suse.com>
To: Jeff Layton <jlayton@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Martin Wilck <mwilck@suse.de>,
linux-fsdevel@vger.kernel.org,
Frank Filz <ffilzlnx@mindspring.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/9 v3] locks: avoid thundering-herd wake-ups
Date: Wed, 24 Oct 2018 09:43:54 +1100 [thread overview]
Message-ID: <154033435272.29542.13985568983074440924.stgit@noble> (raw)
This took longer that I had wanted, due to various reasons - sorry.
And I'm now posting it in a merge window, which is not ideal. I don't
expect it to be included in this merge window and I won't be at all
impatient for review, but I didn't want to delay it further.
Testing found some problems, particularly the need to use
locks_copy_lock in NFS. And there was a small thinko in there that
effectively removed all the speed gains :-(
But this version:
- shows excellent scalability with lots of threads on lots of CPUs
contending on a single file
- avoids the problems that Bruce found
- seems to work.
Thanks,
NeilBrown
---
NeilBrown (9):
fs/locks: rename some lists and pointers.
fs/locks: split out __locks_wake_up_blocks().
NFS: use locks_copy_lock() to copy locks.
fs/locks: allow a lock request to block other requests.
fs/locks: always delete_block after waiting.
fs/locks: change all *_conflict() functions to return bool.
fs/locks: create a tree of dependent requests.
locks: merge posix_unblock_lock() and locks_delete_block()
VFS: locks: remove unnecessary white space.
fs/cifs/file.c | 4 -
fs/lockd/svclock.c | 2
fs/locks.c | 231 ++++++++++++++++++++++-----------------
fs/nfs/nfs4proc.c | 6 +
fs/nfsd/nfs4state.c | 6 +
include/linux/fs.h | 11 +-
include/trace/events/filelock.h | 16 +--
7 files changed, 153 insertions(+), 123 deletions(-)
--
Signature
next reply other threads:[~2018-10-23 22:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 22:43 NeilBrown [this message]
2018-10-23 22:43 ` [PATCH 8/9] locks: merge posix_unblock_lock() and locks_delete_block() NeilBrown
2018-10-23 22:43 ` [PATCH 6/9] fs/locks: change all *_conflict() functions to return bool NeilBrown
2018-10-23 22:43 ` [PATCH 3/9] NFS: use locks_copy_lock() to copy locks NeilBrown
2018-10-23 22:43 ` [PATCH 2/9] fs/locks: split out __locks_wake_up_blocks() NeilBrown
2018-10-23 22:43 ` [PATCH 9/9] VFS: locks: remove unnecessary white space NeilBrown
2018-10-23 22:43 ` [PATCH 7/9] fs/locks: create a tree of dependent requests NeilBrown
2018-10-23 22:43 ` [PATCH 1/9] fs/locks: rename some lists and pointers NeilBrown
2018-10-23 22:43 ` [PATCH 4/9] fs/locks: allow a lock request to block other requests NeilBrown
2018-10-23 22:43 ` [PATCH 5/9] fs/locks: always delete_block after waiting NeilBrown
2018-10-25 16:04 ` [PATCH 0/9 v3] locks: avoid thundering-herd wake-ups J. Bruce Fields
2018-10-25 19:27 ` Martin Wilck
2018-10-26 13:46 ` Jeff Layton
2018-10-28 22:43 ` NeilBrown
2018-10-29 1:56 ` NeilBrown
2018-10-29 12:38 ` Jeff Layton
2018-10-30 12:04 ` Jeff Layton
2018-10-30 17:56 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154033435272.29542.13985568983074440924.stgit@noble \
--to=neilb@suse.com \
--cc=bfields@fieldses.org \
--cc=ffilzlnx@mindspring.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mwilck@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.