From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v11] Add cli and ioctl to forget scanned device(s)
Date: Fri, 26 Oct 2018 22:27:46 +0800 [thread overview]
Message-ID: <1540564068-12918-1-git-send-email-anand.jain@oracle.com> (raw)
v11:
btrfs-progs: Bring the code into the else part of if(forget).
Use strerror to print the erorr instead of ret.
v10:
Make btrfs-progs changes more readable.
With an effort to keep the known bug [1] as it is..
[1]
The cli 'btrfs device scan --all /dev/sdb' which should have scanned
only one device, ends up scanning all the devices and I am not trying
to fix this bug in this patch because..
. -d|--all is marked as deprecated, I hope -d option would go away
. For now some script might be using this bug as a feature, and fixing
this bug might lead to mount failure.
v9:
Make forget as a btrfs device scan option.
Use forget in the fstests, now you can run fstests with btrfs as rootfs
which helps to exercise the uuid_mutex lock.
v8:
Change log update in the kernel patch.
v7:
Use struct btrfs_ioctl_vol_args (instead of struct
btrfs_ioctl_vol_args_v2) as its inline with other ioctl
btrfs-control
The CLI usage/features remains same. However internally the ioctl flag
is not required to delete all the unmounted devices. Instead leave
btrfs_ioctl_vol_args::name NULL.
v6:
Use the changed fn name btrfs_free_stale_devices().
Change in title:
Old v5:
Cover-letter:
[PATCH v5] Add cli and ioctl to ignore a scanned device
Kernel:
[PATCH v5] btrfs: introduce feature to ignore a btrfs device
Progs:
[PATCH v5] btrfs-progs: add 'btrfs device ignore' cli
v5:
Adds feature to delete all stale devices
Reuses btrfs_free_stale_devices() fn and so depends on the
patch-set [1] in the ML.
Uses struct btrfs_ioctl_vol_args_v2 instead of
struct btrfs_ioctl_vol_args as arg
Does the device path matching instead of btrfs_device matching
(we won't delete the mounted device as btrfs_free_stale_devices()
checks for it)
v4:
No change. But as the ML thread may be confusing, so resend.
v3:
No change. Send to correct ML.
v2:
Accepts review from Nikolay, details are in the specific patch.
Patch 1/2 is renamed from
[PATCH 1/2] btrfs: refactor btrfs_free_stale_device() to get device list delete
to
[PATCH 1/2] btrfs: add function to device list delete
Adds cli and ioctl to forget a scanned device or forget all stale
devices in the kernel.
Anand Jain (1):
btrfs: introduce feature to forget a btrfs device
fs/btrfs/super.c | 3 +++
fs/btrfs/volumes.c | 9 +++++++++
fs/btrfs/volumes.h | 1 +
include/uapi/linux/btrfs.h | 2 ++
4 files changed, 15 insertions(+)
Anand Jain (1):
btrfs-progs: add cli to forget one or all scanned devices
cmds-device.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++---------
ioctl.h | 2 ++
2 files changed, 56 insertions(+), 9 deletions(-)
[1]
Anand Jain (1):
fstests: btrfs use forget if not reload
common/btrfs | 20 ++++++++++++++++++++
tests/btrfs/124 | 6 +++---
tests/btrfs/125 | 6 +++---
tests/btrfs/154 | 6 +++---
tests/btrfs/164 | 4 ++--
5 files changed, 31 insertions(+), 11 deletions(-)
--
1.8.3.1
next reply other threads:[~2018-10-26 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 14:27 Anand Jain [this message]
2018-10-26 14:27 ` [PATCH] btrfs: introduce feature to forget a btrfs device Anand Jain
2018-10-26 14:34 ` Nikolay Borisov
2018-10-26 14:27 ` [PATCH] btrfs-progs: add cli to forget one or all scanned devices Anand Jain
2018-10-26 14:36 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540564068-12918-1-git-send-email-anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.