All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Thierry <julien.thierry@arm.com>
To: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu
Cc: andre.przywara@arm.com, Sami Mujawar <sami.mujawar@arm.com>,
	will.deacon@arm.com
Subject: [PATCH kvmtool v2 1/6] rtc: Initialize the Register D for MC146818 RTC
Date: Thu, 10 Jan 2019 14:20:41 +0000	[thread overview]
Message-ID: <1547130046-14729-2-git-send-email-julien.thierry@arm.com> (raw)
In-Reply-To: <1547130046-14729-1-git-send-email-julien.thierry@arm.com>

From: Sami Mujawar <sami.mujawar@arm.com>

Some software drivers check the VRT bit (BIT7) of Register D before
using the MC146818 RTC. Initialized the VRT bit in rtc__init() to
indicate that the RAM and time contents are valid.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Julien Thierry <julien.thierry@arm.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
---
 hw/rtc.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/hw/rtc.c b/hw/rtc.c
index 0649b5d..c1fa72f 100644
--- a/hw/rtc.c
+++ b/hw/rtc.c
@@ -25,6 +25,11 @@
 #define RTC_REG_C			0x0C
 #define RTC_REG_D			0x0D
 
+/*
+ * Register D Bits
+ */
+#define RTC_REG_D_VRT			(1 << 7)
+
 struct rtc_device {
 	u8			cmos_idx;
 	u8			cmos_data[128];
@@ -140,6 +145,9 @@ int rtc__init(struct kvm *kvm)
 		return r;
 	}
 
+	/* Set the VRT bit in Register D to indicate valid RAM and time */
+	rtc.cmos_data[RTC_REG_D] = RTC_REG_D_VRT;
+
 	return r;
 }
 dev_init(rtc__init);
-- 
1.9.1

  reply	other threads:[~2019-01-10 14:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 14:20 [PATCH kvmtool v2 0/6] arm: Add support for firmware booting Julien Thierry
2019-01-10 14:20 ` Julien Thierry [this message]
2019-01-10 14:20 ` [PATCH kvmtool v2 2/6] arm: Move firmware function Julien Thierry
2019-01-10 14:20 ` [PATCH kvmtool v2 3/6] builtin-run: Do not look for default kernel when firmware is provided Julien Thierry
2019-01-10 14:20 ` [PATCH kvmtool v2 4/6] arm: Support firmware loading Julien Thierry
2019-01-11 18:07   ` Andre Przywara
2019-01-14  9:50     ` Vladimir Murzin
2019-01-10 14:20 ` [PATCH kvmtool v2 5/6] kvm: Add arch specific reset Julien Thierry
2019-01-10 14:20 ` [PATCH kvmtool v2 6/6] arm: Support non-volatile memory Julien Thierry
2019-01-22  7:10 ` [PATCH kvmtool v2 0/6] arm: Add support for firmware booting Will Deacon
2019-01-22  9:00   ` Julien Thierry
2019-01-30 18:19     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1547130046-14729-2-git-send-email-julien.thierry@arm.com \
    --to=julien.thierry@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=sami.mujawar@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.