From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH v8 6/6] drm/i915/selftests: Context SSEU reconfiguration tests
Date: Thu, 24 Jan 2019 12:03:22 +0000 [thread overview]
Message-ID: <154833140216.30784.17522298775835708336@skylake-alporthouse-com> (raw)
In-Reply-To: <20190124115942.2251-1-tvrtko.ursulin@linux.intel.com>
Quoting Tvrtko Ursulin (2019-01-24 11:59:42)
> +static int
> +__read_slice_count(struct drm_i915_private *i915,
> + struct i915_gem_context *ctx,
> + struct intel_engine_cs *engine,
> + struct drm_i915_gem_object *obj,
> + struct igt_spinner *spin,
> + u32 *rpcs)
> +{
> + struct i915_request *rq = NULL;
> + u32 s_mask, s_shift;
> + unsigned int cnt;
> + u32 *buf, val;
> + long ret;
> +
> + ret = emit_rpcs_query(obj, ctx, engine, &rq);
> + if (ret)
> + return ret;
> +
> + if (spin)
> + igt_spinner_end(spin);
> +
> + ret = i915_request_wait(rq, I915_WAIT_LOCKED, MAX_SCHEDULE_TIMEOUT);
> + if (ret < 0)
> + return ret;
> +
> + i915_request_put(rq);
put before ret and I'm happy.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-01-24 12:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 11:41 [PATCH 0/6] Per context dynamic (sub)slice power-gating Tvrtko Ursulin
2019-01-24 11:41 ` [PATCH 1/6] drm/i915/execlists: Move RPCS setup to context pin Tvrtko Ursulin
2019-01-24 11:41 ` [PATCH 2/6] drm/i915: Record the sseu configuration per-context & engine Tvrtko Ursulin
2019-01-24 11:42 ` [PATCH 3/6] drm/i915/perf: lock powergating configuration to default when active Tvrtko Ursulin
2019-01-24 11:42 ` [PATCH 4/6] drm/i915: Add timeline barrier support Tvrtko Ursulin
2019-01-24 13:27 ` Chris Wilson
2019-01-24 21:25 ` [PATCH v4] " Chris Wilson
2019-01-24 11:42 ` [PATCH 5/6] drm/i915: Expose RPCS (SSEU) configuration to userspace (Gen11 only) Tvrtko Ursulin
2019-01-24 23:55 ` Chris Wilson
2019-01-24 11:42 ` [PATCH 6/6] drm/i915/selftests: Context SSEU reconfiguration tests Tvrtko Ursulin
2019-01-24 11:59 ` [PATCH v8 " Tvrtko Ursulin
2019-01-24 12:03 ` Chris Wilson [this message]
2019-01-24 12:27 ` [PATCH v9 " Tvrtko Ursulin
2019-01-24 11:52 ` ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev15) Patchwork
2019-01-24 11:55 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-01-24 12:10 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-01-24 12:13 ` ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev16) Patchwork
2019-01-24 12:15 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-01-24 12:30 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-24 12:55 ` ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev17) Patchwork
2019-01-24 12:58 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-01-24 13:32 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-24 16:21 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-01-24 21:31 ` ✗ Fi.CI.BAT: failure for Per context dynamic (sub)slice power-gating (rev18) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154833140216.30784.17522298775835708336@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.