From: "Xin Li (Talons)" <xin.li@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, Xin Li <talons.lee@gmail.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
Sergey Dyasli <sergey.dyasli@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Igor Druzhinin <igor.druzhinin@citrix.com>
Subject: Re: [PATCH v2 1/1] hvmloader: add SMBIOS type 2 info for customized string
Date: Mon, 1 Apr 2019 01:24:21 +0000 [thread overview]
Message-ID: <1554081861524.44935@citrix.com> (raw)
In-Reply-To: <5C9DFCAF0200007800222C56@prv1-mh.provo.novell.com>
> So this is the 3rd variant of v2 that you've sent, without making it clear
> what the difference is. I suppose you've addressed my one remaining
> cosmetic request and added my R-b, but we should be at v4 then.
Yes. Since these are all style change, I kept the version number 2.
Sorry for the confusion.
Kind Regards
Xin(Talons)
________________________________________
From: Jan Beulich <JBeulich@suse.com>
Sent: Friday, March 29, 2019 7:08 PM
To: Xin Li
Cc: Andrew Cooper; Igor Druzhinin; Sergey Dyasli; Xin Li (Talons); xen-devel@lists.xen.org
Subject: Re: [PATCH v2 1/1] hvmloader: add SMBIOS type 2 info for customized string
>>> On 29.03.19 at 04:28, <talons.lee@gmail.com> wrote:
> Extend smbios type 2 struct to match specification, add support to
> write it when customized string provided and no smbios passed in.
>
> Signed-off-by: Xin Li <xin.li@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Igor Druzhinin <igor.druzhinin@citrix.com>
> CC: Sergey Dyasli <sergey.dyasli@citrix.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
>
> v2
> 1: write the struct if any of the strings is provided
> 2: add contained_handles as flexible array member
> 3: update commit message and fix style issue
So this is the 3rd variant of v2 that you've sent, without making it clear
what the difference is. I suppose you've addressed my one remaining
cosmetic request and added my R-b, but we should be at v4 then.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-04-01 1:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 3:28 [PATCH v2 1/1] hvmloader: add SMBIOS type 2 info for customized string Xin Li
2019-03-29 11:08 ` Jan Beulich
2019-04-01 1:24 ` Xin Li (Talons) [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-28 13:56 Xin Li
2019-03-28 14:26 ` Jan Beulich
2019-03-28 9:05 Xin Li
2019-03-28 10:48 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554081861524.44935@citrix.com \
--to=xin.li@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=igor.druzhinin@citrix.com \
--cc=sergey.dyasli@citrix.com \
--cc=talons.lee@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.