All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Souza, Jose" <jose.souza@intel.com>
To: "Intel-gfx@lists.freedesktop.org"
	<Intel-gfx@lists.freedesktop.org>,
	"Taylor, Clinton A" <clinton.a.taylor@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: support ddr5 mem types
Date: Thu, 4 Feb 2021 20:31:46 +0000	[thread overview]
Message-ID: <155766d0bcfaf157ee5439cd33ff9ea971b1d228.camel@intel.com> (raw)
In-Reply-To: <20210204200458.21875-1-clinton.a.taylor@intel.com>

On Thu, 2021-02-04 at 12:04 -0800, clinton.a.taylor@intel.com wrote:
> From: Clint Taylor <clinton.a.taylor@intel.com>
> 
> Add DDR5 and LPDDR5 return values from punit fw.
> 

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> BSPEC: 54023
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_bw.c | 12 +++++++++++-
>  drivers/gpu/drm/i915/i915_drv.h         |  4 +++-
>  drivers/gpu/drm/i915/intel_dram.c       |  6 ++++++
>  3 files changed, 20 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> index ba9e713585e7..d122b9965532 100644
> --- a/drivers/gpu/drm/i915/display/intel_bw.c
> +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> @@ -78,7 +78,17 @@ static int icl_get_qgv_points(struct drm_i915_private *dev_priv,
>  	qi->num_points = dram_info->num_qgv_points;
>  
> 
> 
> 
>  	if (IS_GEN(dev_priv, 12))
> -		qi->t_bl = dev_priv->dram_info.type == INTEL_DRAM_DDR4 ? 4 : 16;
> +		switch (dram_info->type) {
> +		case INTEL_DRAM_DDR4:
> +			qi->t_bl = 4;
> +			break;
> +		case INTEL_DRAM_DDR5:
> +			qi->t_bl = 8;
> +			break;
> +		default:
> +			qi->t_bl = 16;
> +			break;
> +		}
>  	else if (IS_GEN(dev_priv, 11))
>  		qi->t_bl = dev_priv->dram_info.type == INTEL_DRAM_DDR4 ? 4 : 8;
>  
> 
> 
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index a2fd7e5039b3..8083a50908bf 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1136,7 +1136,9 @@ struct drm_i915_private {
>  			INTEL_DRAM_DDR3,
>  			INTEL_DRAM_DDR4,
>  			INTEL_DRAM_LPDDR3,
> -			INTEL_DRAM_LPDDR4
> +			INTEL_DRAM_LPDDR4,
> +			INTEL_DRAM_DDR5,
> +			INTEL_DRAM_LPDDR5,
>  		} type;
>  		u8 num_qgv_points;
>  	} dram_info;
> diff --git a/drivers/gpu/drm/i915/intel_dram.c b/drivers/gpu/drm/i915/intel_dram.c
> index 73d256fc6830..1e53c017c30d 100644
> --- a/drivers/gpu/drm/i915/intel_dram.c
> +++ b/drivers/gpu/drm/i915/intel_dram.c
> @@ -427,6 +427,12 @@ static int icl_pcode_read_mem_global_info(struct drm_i915_private *dev_priv)
>  		case 0:
>  			dram_info->type = INTEL_DRAM_DDR4;
>  			break;
> +		case 1:
> +			dram_info->type = INTEL_DRAM_DDR5;
> +			break;
> +		case 2:
> +			dram_info->type = INTEL_DRAM_LPDDR5;
> +			break;
>  		case 3:
>  			dram_info->type = INTEL_DRAM_LPDDR4;
>  			break;

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-02-04 20:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 20:04 [Intel-gfx] [PATCH] drm/i915/display: support ddr5 mem types clinton.a.taylor
2021-02-04 20:31 ` Souza, Jose [this message]
2021-02-04 23:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-02-05  7:40 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-02-05 13:25   ` Souza, Jose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=155766d0bcfaf157ee5439cd33ff9ea971b1d228.camel@intel.com \
    --to=jose.souza@intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=clinton.a.taylor@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.