From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/6] drm/i915/sdvo: Reduce the size of the on stack buffers
Date: Wed, 19 Jun 2019 19:21:48 +0100 [thread overview]
Message-ID: <156096850888.664.14223582224163086211@skylake-alporthouse-com> (raw)
In-Reply-To: <20190619180312.31817-5-ville.syrjala@linux.intel.com>
Quoting Ville Syrjala (2019-06-19 19:03:11)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The strings we want to print to the on stack buffers should
> be no more than
> 8 * 3 + strlen("(GET_SCALED_HDTV_RESOLUTION_SUPPORT)") + 1 = 61
> bytes. So let's shrink the buffers down to 64 bytes.
>
max args_len does seem to 8, and it gets padded out to 8.
> Also switch the BUG_ON()s to WARN_ON()s if I made a mistake in
> my arithmentic.
With the command name macro, could it not do some thing like
BUILD_BUG_ON(sizeof(#cmd) > DBG_LEN) ?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-19 18:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 18:03 [PATCH 1/6] drm/i915/sdvo: Fix handling if zero hbuf size Ville Syrjala
2019-06-19 18:03 ` [PATCH 2/6] drm/i915/sdvo: Use named initializers for the SDVO command names Ville Syrjala
2019-06-19 18:08 ` Chris Wilson
2019-06-19 18:03 ` [PATCH 3/6] drm/i915/sdvo: Remove duplicate SET_INPUT_TIMINGS_PART1 cmd name string Ville Syrjala
2019-06-19 18:11 ` Chris Wilson
2019-06-19 18:03 ` [PATCH 4/6] drm/i915/sdvo: Shrink sdvo_cmd_names[] strings Ville Syrjala
2019-06-19 18:13 ` Chris Wilson
2019-06-19 18:03 ` [PATCH 5/6] drm/i915/sdvo: Reduce the size of the on stack buffers Ville Syrjala
2019-06-19 18:21 ` Chris Wilson [this message]
2019-06-24 16:40 ` Ville Syrjälä
2019-06-19 18:03 ` [PATCH 6/6] drm/i915/sdvo: Add helpers to get the cmd/status string Ville Syrjala
2019-06-19 18:15 ` Chris Wilson
2019-06-19 18:32 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/6] drm/i915/sdvo: Fix handling if zero hbuf size Patchwork
2019-06-19 18:52 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-20 13:39 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-07-10 13:37 ` [PATCH 1/6] " Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156096850888.664.14223582224163086211@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.