From: Chris Wilson <chris@chris-wilson.co.uk>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [CI 4/4] drm/i915/uc: Stop sanitizing enable_guc modparam
Date: Thu, 01 Aug 2019 08:04:25 +0100 [thread overview]
Message-ID: <156464306539.2512.13874180281743403073@skylake-alporthouse-com> (raw)
In-Reply-To: <20190731223321.36436-5-michal.wajdeczko@intel.com>
Quoting Michal Wajdeczko (2019-07-31 23:33:21)
> As we already track GuC/HuC uses by other means than modparam
> there is no point in sanitizing it. Just scan modparam for
> major discrepancies between what was requested vs actual.
>
> v2: rebased, reworded info messages
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
I think because we need to explicitly set enable_guc|=2 currently, it
shouldn't have any observable differences in the igt telltale. (And if
it did, it's not the end of the world, it's only a debug aide-memoire
that we can replace later.)
Reviewed-by-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-01 7:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 22:33 [CI 0/4] Don't sanitize enable_guc Michal Wajdeczko
2019-07-31 22:33 ` [CI 1/4] drm/i915/uc: Rename intel_uc_is_using* into intel_uc_supports* Michal Wajdeczko
2019-07-31 22:33 ` [CI 2/4] drm/i915/uc: Consider enable_guc modparam during fw selection Michal Wajdeczko
2019-07-31 22:33 ` [CI 3/4] drm/i915/guc: Use dedicated flag to track submission mode Michal Wajdeczko
2019-07-31 22:33 ` [CI 4/4] drm/i915/uc: Stop sanitizing enable_guc modparam Michal Wajdeczko
2019-08-01 7:04 ` Chris Wilson [this message]
2019-08-01 13:28 ` [CI v2 " Michal Wajdeczko
2019-08-01 13:08 ` [CI " Michal Wajdeczko
2019-08-01 20:27 ` ✓ Fi.CI.BAT: success for Don't sanitize enable_guc (rev4) Patchwork
2019-08-02 15:56 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156464306539.2512.13874180281743403073@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.