From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Replace obj->pin_global with obj->frontbuffer
Date: Fri, 23 Aug 2019 17:38:49 +0100 [thread overview]
Message-ID: <156657832951.4019.10986389936065255418@skylake-alporthouse-com> (raw)
In-Reply-To: <20190823162041.9482-1-chris@chris-wilson.co.uk>
Quoting Chris Wilson (2019-08-23 17:20:41)
> @@ -220,11 +220,18 @@ static void frontbuffer_release(struct kref *ref)
> {
> struct intel_frontbuffer *front =
> container_of(ref, typeof(*front), ref);
> + struct drm_i915_gem_object *obj = front->obj;
> + struct i915_vma *vma;
>
> - front->obj->frontbuffer = NULL;
> - spin_unlock(&to_i915(front->obj->base.dev)->fb_tracking.lock);
> + spin_lock(&obj->vma.lock);
> + for_each_ggtt_vma(vma, obj)
> + vma->display_alignment = I915_GTT_PAGE_SIZE;
Should be I915_GTT_MIN_ALIGNMENT instead.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-23 16:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 16:20 [PATCH] drm/i915: Replace obj->pin_global with obj->frontbuffer Chris Wilson
2019-08-23 16:38 ` Chris Wilson [this message]
2019-08-23 16:39 ` Chris Wilson
2019-08-23 16:48 ` Ville Syrjälä
2019-08-23 17:03 ` Chris Wilson
2019-08-23 17:11 ` Chris Wilson
2019-09-02 11:50 ` Ville Syrjälä
2019-08-23 20:12 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Replace obj->pin_global with obj->frontbuffer (rev3) Patchwork
2019-08-23 21:05 ` ✓ Fi.CI.BAT: success " Patchwork
2019-08-25 0:22 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156657832951.4019.10986389936065255418@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.