Re: [libvirt] [PULL 0/9] Ide patches - no-reply

From: no-reply@patchew.org
To: jsnow@redhat.com
Cc: kwolf@redhat.com, peter.maydell@linaro.org, thuth@redhat.com,
	qemu-block@nongnu.org, mst@redhat.com, libvir-list@redhat.com,
	lersek@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com,
	jsnow@redhat.com, arei.gonglei@huawei.com, kraxel@redhat.com,
	stefanha@redhat.com, lvivier@redhat.com, pbonzini@redhat.com,
	fam@euphon.net, philmd@redhat.com
Subject: Re: [libvirt] [PULL 0/9] Ide patches
Date: Thu, 31 Oct 2019 07:04:04 -0700 (PDT)	[thread overview]
Message-ID: <157253064186.11413.2788074989565438899@37313f22b938> (raw)
In-Reply-To: <20191031105904.12194-1-jsnow@redhat.com>

Patchew URL: https://patchew.org/QEMU/20191031105904.12194-1-jsnow@redhat.com/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [libvirt] [PULL 0/9] Ide patches
Type: series
Message-id: 20191031105904.12194-1-jsnow@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
d278ccf hd-geo-test: Add tests for lchs override
28807d7 bootdevice: FW_CFG interface for LCHS values
11f27f1 bootdevice: Refactor get_boot_devices_list
e032fef bootdevice: Gather LCHS from all relevant devices
74eb334 scsi: Propagate unrealize() callback to scsi-hd
e211495 bootdevice: Add interface to gather LCHS
a683977 block: Support providing LCHS from user
071ac63 block: Refactor macros - fix tabbing
90e6789 IDE: deprecate ide-drive

=== OUTPUT BEGIN ===
1/9 Checking commit 90e67898e3b9 (IDE: deprecate ide-drive)
2/9 Checking commit 071ac63ed092 (block: Refactor macros - fix tabbing)
ERROR: Macros with complex values should be enclosed in parenthesis
#58: FILE: include/hw/block/block.h:65:
+#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf)                      \
+    DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0),                  \
+    DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0),                \
     DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0)

total: 1 errors, 0 warnings, 37 lines checked

Patch 2/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/9 Checking commit a68397755180 (block: Support providing LCHS from user)
4/9 Checking commit e21149531919 (bootdevice: Add interface to gather LCHS)
5/9 Checking commit 74eb33489f71 (scsi: Propagate unrealize() callback to scsi-hd)
6/9 Checking commit e032fefe3098 (bootdevice: Gather LCHS from all relevant devices)
7/9 Checking commit 11f27f1f9e10 (bootdevice: Refactor get_boot_devices_list)
8/9 Checking commit 28807d78bb01 (bootdevice: FW_CFG interface for LCHS values)
9/9 Checking commit d278ccfd1965 (hd-geo-test: Add tests for lchs override)
WARNING: Block comments use a leading /* on a separate line
#607: FILE: tests/hd-geo-test.c:965:
+                       "skipping hd-geo/override/* tests");

total: 0 errors, 1 warnings, 578 lines checked

Patch 9/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20191031105904.12194-1-jsnow@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com