From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Jani Nikula" <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for video, drm, etc: constify fbops in struct fb_info (rev2)
Date: Tue, 03 Dec 2019 19:50:53 -0000 [thread overview]
Message-ID: <157540265342.4658.3437459686533878693@emeril.freedesktop.org> (raw)
In-Reply-To: <cover.1575390740.git.jani.nikula@intel.com>
== Series Details ==
Series: video, drm, etc: constify fbops in struct fb_info (rev2)
URL : https://patchwork.freedesktop.org/series/70198/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
5109f996a5c8 video: fbdev: atyfb: modify the static fb_ops directly
-:21: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#21: FILE: drivers/video/fbdev/aty/atyfb.h:344:
+extern int aty_init_cursor(struct fb_info *info, struct fb_ops *atyfb_ops);
total: 0 errors, 0 warnings, 1 checks, 44 lines checked
d1dd9ad23a85 video: fbdev: mb862xx: modify the static fb_ops directly
-:21: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#21: FILE: drivers/video/fbdev/mb862xx/mb862xxfb.h:92:
+extern void mb862xxfb_init_accel(struct fb_info *info, struct fb_ops *fbops, int xres);
total: 0 errors, 0 warnings, 1 checks, 56 lines checked
c9a3fc359d55 video: fbdev: nvidia: modify the static fb_ops directly
-:57: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#57: FILE: drivers/video/fbdev/nvidia/nvidia.c:1169:
if (!hwcur)
+ nvidia_fb_ops.fb_cursor = NULL;
total: 0 errors, 1 warnings, 0 checks, 43 lines checked
045da6c271da video: fbdev: uvesafb: modify the static fb_ops directly
-:12: WARNING:BAD_SIGN_OFF: Duplicate signature
#12:
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
total: 0 errors, 1 warnings, 0 checks, 16 lines checked
89a8b3ad953d video: fbdev: make fbops member of struct fb_info a const pointer
7db4d9e5a7ae drm: constify fb ops across all drivers
70ac7fa0dc3d video: fbdev: intelfb: use const pointer for fb_ops
aa0f9fd709a6 video: constify fb ops across all drivers
c37885d39521 HID: picoLCD: constify fb ops
d5cc24c141ca media: constify fb ops across all drivers
4700338b3b91 samples: vfio-mdev: constify fb ops
b4c9b961101f auxdisplay: constify fb ops
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-03 19:50 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 16:38 [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info Jani Nikula
2019-12-03 16:38 ` [Intel-gfx] " Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-03 16:38 ` [PATCH v3 01/12] video: fbdev: atyfb: modify the static fb_ops directly Jani Nikula
2019-12-03 16:38 ` [Intel-gfx] " Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-03 16:46 ` Daniel Vetter
2019-12-03 16:46 ` [Intel-gfx] " Daniel Vetter
2019-12-03 16:46 ` Daniel Vetter
2019-12-03 16:38 ` [PATCH v3 02/12] video: fbdev: mb862xx: " Jani Nikula
2019-12-03 16:38 ` [Intel-gfx] " Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-03 16:50 ` Daniel Vetter
2019-12-03 16:50 ` [Intel-gfx] " Daniel Vetter
2019-12-03 16:50 ` Daniel Vetter
2019-12-03 16:38 ` [PATCH v3 03/12] video: fbdev: nvidia: " Jani Nikula
2019-12-03 16:38 ` [Intel-gfx] " Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-03 16:54 ` [Intel-gfx] " Daniel Vetter
2019-12-03 16:54 ` Daniel Vetter
2019-12-03 16:54 ` Daniel Vetter
2019-12-03 16:38 ` [PATCH v3 04/12] video: fbdev: uvesafb: " Jani Nikula
2019-12-03 16:38 ` [Intel-gfx] " Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-03 17:03 ` [Intel-gfx] " Daniel Vetter
2019-12-03 17:03 ` Daniel Vetter
2019-12-03 17:03 ` Daniel Vetter
2019-12-04 6:31 ` Jani Nikula
2019-12-04 6:31 ` Jani Nikula
2019-12-04 6:31 ` Jani Nikula
2019-12-03 16:38 ` [PATCH v3 05/12] video: fbdev: make fbops member of struct fb_info a const pointer Jani Nikula
2019-12-03 16:38 ` [Intel-gfx] " Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-05 0:12 ` kbuild test robot
2019-12-05 0:12 ` kbuild test robot
2019-12-05 0:12 ` [Intel-gfx] " kbuild test robot
2019-12-05 0:12 ` kbuild test robot
2019-12-05 22:25 ` kbuild test robot
2019-12-03 16:38 ` [PATCH v3 06/12] drm: constify fb ops across all drivers Jani Nikula
2019-12-03 16:38 ` [Intel-gfx] " Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-03 16:38 ` [PATCH v3 07/12] video: fbdev: intelfb: use const pointer for fb_ops Jani Nikula
2019-12-03 16:38 ` [Intel-gfx] " Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-03 17:09 ` Daniel Vetter
2019-12-03 17:09 ` [Intel-gfx] " Daniel Vetter
2019-12-03 17:09 ` Daniel Vetter
2019-12-03 16:38 ` [PATCH v3 08/12] video: constify fb ops across all drivers Jani Nikula
2019-12-03 16:38 ` [Intel-gfx] " Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-05 9:37 ` [Intel-gfx] " Jani Nikula
2019-12-05 9:37 ` Jani Nikula
2019-12-05 9:37 ` Jani Nikula
2019-12-03 16:38 ` [PATCH v3 09/12] HID: picoLCD: constify fb ops Jani Nikula
2019-12-03 16:38 ` [Intel-gfx] " Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-09 13:59 ` [Intel-gfx] " Jani Nikula
2019-12-09 13:59 ` Jani Nikula
2019-12-09 13:59 ` Jani Nikula
2019-12-09 13:59 ` Jani Nikula
2019-12-03 16:38 ` [PATCH v3 10/12] media: constify fb ops across all drivers Jani Nikula
2019-12-03 16:38 ` [Intel-gfx] " Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-04 11:33 ` Sakari Ailus
2019-12-04 11:33 ` [Intel-gfx] " Sakari Ailus
2019-12-04 11:33 ` Sakari Ailus
2019-12-04 11:33 ` Sakari Ailus
2019-12-05 9:40 ` Jani Nikula
2019-12-05 9:40 ` [Intel-gfx] " Jani Nikula
2019-12-05 9:40 ` Jani Nikula
2019-12-05 9:40 ` Jani Nikula
2019-12-12 9:02 ` Hans Verkuil
2019-12-12 9:02 ` [Intel-gfx] " Hans Verkuil
2019-12-12 9:02 ` Hans Verkuil
2019-12-12 9:02 ` Hans Verkuil
2019-12-13 10:41 ` Jani Nikula
2019-12-13 10:41 ` [Intel-gfx] " Jani Nikula
2019-12-13 10:41 ` Jani Nikula
2019-12-13 10:41 ` Jani Nikula
2019-12-03 16:38 ` [PATCH v3 11/12] samples: vfio-mdev: constify fb ops Jani Nikula
2019-12-03 16:38 ` [Intel-gfx] " Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-09 14:01 ` Jani Nikula
2019-12-09 14:01 ` [Intel-gfx] " Jani Nikula
2019-12-09 14:01 ` Jani Nikula
2019-12-09 14:01 ` Jani Nikula
2019-12-09 18:43 ` Kirti Wankhede
2019-12-09 18:55 ` Kirti Wankhede
2019-12-09 18:43 ` [Intel-gfx] " Kirti Wankhede
2019-12-09 18:43 ` Kirti Wankhede
2019-12-10 6:53 ` Jani Nikula
2019-12-10 6:53 ` [Intel-gfx] " Jani Nikula
2019-12-10 6:53 ` Jani Nikula
2019-12-10 6:53 ` Jani Nikula
2019-12-03 16:38 ` [PATCH v3 12/12] auxdisplay: " Jani Nikula
2019-12-03 16:38 ` [Intel-gfx] " Jani Nikula
2019-12-03 16:38 ` Jani Nikula
2019-12-09 14:03 ` Jani Nikula
2019-12-09 14:03 ` [Intel-gfx] " Jani Nikula
2019-12-09 14:03 ` Jani Nikula
2019-12-10 19:08 ` Miguel Ojeda
2019-12-10 19:08 ` Miguel Ojeda
2019-12-11 11:11 ` Jani Nikula
2019-12-11 11:11 ` [Intel-gfx] " Jani Nikula
2019-12-11 11:11 ` Jani Nikula
2019-12-11 8:35 ` robin
2019-12-11 8:35 ` [Intel-gfx] " robin
2019-12-11 8:35 ` robin
2019-12-03 16:42 ` [Intel-gfx] [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info Jani Nikula
2019-12-03 16:42 ` Jani Nikula
2019-12-03 16:42 ` Jani Nikula
2019-12-03 16:42 ` Jani Nikula
2019-12-03 16:42 ` [Intel-gfx] " Jani Nikula
2019-12-03 19:50 ` Patchwork [this message]
2019-12-03 20:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for video, drm, etc: constify fbops in struct fb_info (rev2) Patchwork
2019-12-04 5:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157540265342.4658.3437459686533878693@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.