From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Cleanups around intel_attached_encoder() & co. (rev2)
Date: Thu, 05 Dec 2019 11:58:40 -0000 [thread overview]
Message-ID: <157554712099.19944.13354537803860395094@emeril.freedesktop.org> (raw)
In-Reply-To: <20191204180549.1267-1-ville.syrjala@linux.intel.com>
== Series Details ==
Series: drm/i915: Cleanups around intel_attached_encoder() & co. (rev2)
URL : https://patchwork.freedesktop.org/series/70456/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
832a1c55fe76 drm/i915/hdcp: Nuke intel_hdcp_transcoder_config()
170ec3b713ff drm/i915: Pass intel_connector to intel_attached_*()
-:557: WARNING:LONG_LINE: line over 100 characters
#557: FILE: drivers/gpu/drm/i915/i915_debugfs.c:4512:
+ intel_dp = enc_to_intel_dp(&intel_attached_encoder(to_intel_connector(connector))->base);
total: 0 errors, 1 warnings, 0 checks, 427 lines checked
38feb26c23df drm/i915: Pass intel_encoder to enc_to_*()
-:520: ERROR:CODE_INDENT: code indent should use tabs where possible
#520: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:4150:
+^I^I required_lanes);$
-:520: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#520: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:4150:
+ intel_tc_port_get_link(enc_to_dig_port(encoder),
+ required_lanes);
-:1499: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "hpd_pulse"
#1499: FILE: drivers/gpu/drm/i915/display/intel_hotplug.c:305:
+ enc_to_dig_port(encoder)->hpd_pulse != NULL;
total: 1 errors, 0 warnings, 2 checks, 1610 lines checked
767c5765e403 drm/i915: Use the passed in encoder
424e6ca96e88 drm/i915: Use intel_attached_encoder()
-:168: WARNING:LONG_LINE: line over 100 characters
#168: FILE: drivers/gpu/drm/i915/display/intel_dp_mst.c:508:
+ if (!intel_attached_encoder(connector)->get_hw_state(intel_attached_encoder(connector), &pipe))
total: 0 errors, 1 warnings, 0 checks, 206 lines checked
27e677f40641 drm/i915: Relocate intel_attached_dp()
4e0931881e22 drm/i915: Use intel_attached_dp() instead of hand rolling it
420c21998dbc drm/i915: Rename conn_to_dig_port() to intel_attached_dig_port()
838d626c5ada drm/i915/hdcp: Clean up local variables
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-05 11:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 18:05 [Intel-gfx] [PATCH 0/9] drm/i915: Cleanups around intel_attached_encoder() & co Ville Syrjala
2019-12-04 18:05 ` [Intel-gfx] [PATCH 1/9] drm/i915/hdcp: Nuke intel_hdcp_transcoder_config() Ville Syrjala
2019-12-05 9:33 ` Ramalingam C
2019-12-04 18:05 ` [Intel-gfx] [PATCH 2/9] drm/i915: Pass intel_connector to intel_attached_*() Ville Syrjala
2020-01-09 7:28 ` Kahola, Mika
2019-12-04 18:05 ` [Intel-gfx] [PATCH 3/9] drm/i915: Pass intel_encoder to enc_to_*() Ville Syrjala
2019-12-18 20:41 ` Juha-Pekka Heikkila
2019-12-04 18:05 ` [Intel-gfx] [PATCH 4/9] drm/i915: Use the passed in encoder Ville Syrjala
2019-12-05 10:24 ` Ramalingam C
2019-12-04 18:05 ` [Intel-gfx] [PATCH 5/9] drm/i915: Use intel_attached_encoder() Ville Syrjala
2019-12-05 10:59 ` Ramalingam C
2019-12-05 11:04 ` Ramalingam C
2019-12-09 15:52 ` Ville Syrjälä
2020-01-21 15:49 ` Juha-Pekka Heikkila
2019-12-04 18:05 ` [Intel-gfx] [PATCH 6/9] drm/i915: Relocate intel_attached_dp() Ville Syrjala
2020-01-13 13:53 ` Kahola, Mika
2019-12-04 18:05 ` [Intel-gfx] [PATCH 7/9] drm/i915: Use intel_attached_dp() instead of hand rolling it Ville Syrjala
2020-01-21 14:46 ` Juha-Pekka Heikkila
2019-12-04 18:05 ` [Intel-gfx] [PATCH 8/9] drm/i915: Rename conn_to_dig_port() to intel_attached_dig_port() Ville Syrjala
2020-01-21 14:46 ` Juha-Pekka Heikkila
2019-12-04 18:05 ` [Intel-gfx] [PATCH 9/9] drm/i915/hdcp: Clean up local variables Ville Syrjala
2019-12-05 10:22 ` Ramalingam C
2019-12-04 23:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Cleanups around intel_attached_encoder() & co Patchwork
2019-12-05 0:15 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2019-12-05 11:58 ` Patchwork [this message]
2019-12-05 12:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Cleanups around intel_attached_encoder() & co. (rev2) Patchwork
2019-12-05 15:06 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157554712099.19944.13354537803860395094@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.