From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 7/8] drm/i915/gt: Remove direct invocation of breadcrumb signaling
Date: Wed, 18 Dec 2019 17:10:47 +0000 [thread overview]
Message-ID: <157668904753.6469.8214860190737663975@skylake-alporthouse-com> (raw)
In-Reply-To: <65d1543e-be04-61ef-3653-51c50f595e5e@linux.intel.com>
Quoting Tvrtko Ursulin (2019-12-18 16:48:20)
>
> On 17/12/2019 09:56, Chris Wilson wrote:
> > Only signal the breadcrumbs from inside the irq_work, simplifying our
> > interface and calling conventions. The micro-optimisation here is that
> > by always using the irq_work interface, we know we are always inside an
> > irq-off critical section for the breadcrumb signaling and can ellide
> > save/restore of the irq flags.
>
> Assuming no significant impact on saturated media workloads:
v5.5-rc1 and v5.5-rc2 have been quite a rollercoaster; but this patch
does not seem to affect wsim, apart from making the flamegraphs tidier.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-18 17:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 9:56 [Intel-gfx] [PATCH 1/8] drm/i915: Unpin vma->obj on early error Chris Wilson
2019-12-17 9:56 ` [PATCH 2/8] drm/i915: Hold reference to intel_frontbuffer as we track activity Chris Wilson
2019-12-17 9:56 ` [Intel-gfx] " Chris Wilson
2019-12-17 9:56 ` [Intel-gfx] [PATCH 3/8] drm/i915/display: Silence powerwell debug Chris Wilson
2019-12-17 9:56 ` [Intel-gfx] [PATCH 4/8] drm/i915/gt: Eliminate the trylock for reading a timeline's hwsp Chris Wilson
2019-12-17 9:56 ` [Intel-gfx] [PATCH 5/8] drm/i915/selftests: Disable heartbeats around long queues Chris Wilson
2019-12-17 9:56 ` [Intel-gfx] [PATCH 6/8] drm/i915/selftests: Impose a timeout for request submission Chris Wilson
2019-12-17 9:56 ` [Intel-gfx] [PATCH 7/8] drm/i915/gt: Remove direct invocation of breadcrumb signaling Chris Wilson
2019-12-18 16:48 ` Tvrtko Ursulin
2019-12-18 17:10 ` Chris Wilson [this message]
2019-12-17 9:56 ` [Intel-gfx] [PATCH 8/8] drm/i915: Tweak scheduler's kick_submission() Chris Wilson
2019-12-17 10:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/8] drm/i915: Unpin vma->obj on early error Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157668904753.6469.8214860190737663975@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.