From: Chris Wilson <chris@chris-wilson.co.uk>
To: Matthew Auld <matthew.william.auld@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 5/7] drm/i915/gt: Ignore stale context state upon resume
Date: Mon, 30 Dec 2019 16:12:52 +0000 [thread overview]
Message-ID: <157772237211.3861.11783918047295549189@skylake-alporthouse-com> (raw)
In-Reply-To: <CAM0jSHOsrHys3HoaKxSXaTyod+EHzc8yC+uvWanZEewysPinPA@mail.gmail.com>
Quoting Matthew Auld (2019-12-30 16:06:47)
> On Sun, 29 Dec 2019 at 18:32, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > static const struct intel_context_ops execlists_context_ops = {
> > @@ -3968,7 +3982,6 @@ static void init_common_reg_state(u32 * const regs,
> > CTX_CTRL_RS_CTX_ENABLE);
> >
> > regs[CTX_RING_CTL] = RING_CTL_SIZE(ring->size) | RING_VALID;
> > - regs[CTX_BB_STATE] = RING_BB_PPGTT;
>
> Zero clue what that does...
It's supposed to be a readonly bit that shows the state of the current
batch buffer, and is supposed to be only set by MI_BB_START. Broadwell
and Braswell disagree with the bspec. C'est la vie.
I broke it out into a separate patch for clarity.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-30 16:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 18:31 [Intel-gfx] [PATCH 1/7] drm/i915/gt: Ensure that all new contexts clear STOP_RING Chris Wilson
2019-12-29 18:31 ` [Intel-gfx] [PATCH 2/7] drm/i915/gt: Avoid using tag 0 for the very first submission Chris Wilson
2019-12-30 13:43 ` Matthew Auld
2019-12-29 18:31 ` [Intel-gfx] [PATCH 3/7] drm/i915/gt: Avoid using the GPU before initialisation Chris Wilson
2019-12-30 13:58 ` Matthew Auld
2019-12-29 18:31 ` [Intel-gfx] [PATCH 4/7] drm/i915/gt: Do not restore invalid RS state Chris Wilson
2019-12-30 14:46 ` Matthew Auld
2019-12-29 18:31 ` [Intel-gfx] [PATCH 5/7] drm/i915/gt: Ignore stale context state upon resume Chris Wilson
2019-12-30 16:06 ` Matthew Auld
2019-12-30 16:12 ` Chris Wilson [this message]
2019-12-29 18:31 ` [Intel-gfx] [PATCH 6/7] drm/i915/gt: Discard stale context state from across idling Chris Wilson
2019-12-30 16:12 ` Matthew Auld
2019-12-29 18:31 ` [Intel-gfx] [PATCH 7/7] drm/i915/gt: Always poison the kernel_context image before unparking Chris Wilson
2019-12-30 16:16 ` Matthew Auld
2019-12-29 19:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915/gt: Ensure that all new contexts clear STOP_RING Patchwork
2019-12-29 20:50 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2019-12-29 22:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915/gt: Ensure that all new contexts clear STOP_RING (rev2) Patchwork
2019-12-30 0:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2019-12-30 11:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/7] drm/i915/gt: Ensure that all new contexts clear STOP_RING (rev3) Patchwork
2019-12-30 13:33 ` [Intel-gfx] [PATCH 1/7] drm/i915/gt: Ensure that all new contexts clear STOP_RING Matthew Auld
2019-12-30 14:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915/gt: Ensure that all new contexts clear STOP_RING (rev4) Patchwork
2019-12-30 21:07 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157772237211.3861.11783918047295549189@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.william.auld@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.