From: Zirong Lang <zlang@redhat.com>
To: yangx.jy@cn.fujitsu.com
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic/135: fix standard error output from _scratch_mkfs
Date: Mon, 22 Feb 2016 04:40:19 -0500 (EST) [thread overview]
Message-ID: <1578053095.20705983.1456134019296.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CADVQ27rD6UX7eechDFxke7aE=ty3NJJJKtKGsDR2sCVR5=EP=w@mail.gmail.com>
2016年2月22日 14:12，"Xiao Yang" <yangx.jy@cn.fujitsu.com>写道：
>
>
>> 2016年2月22日 11:41，"Xiao Yang" <yangx.jy@cn.fujitsu.com> 写道：
>> >
>> > Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
>> > ---
>> > tests/generic/135 | 2 +-
>> > 1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/tests/generic/135 b/tests/generic/135
>> > index 52418f6..5aa880d 100755
>> > --- a/tests/generic/135
>> > +++ b/tests/generic/135
>> > @@ -41,7 +41,7 @@ _supported_os Linux IRIX
>> >
>> > _require_odirect
>> > _require_scratch
>> > -_scratch_mkfs >/dev/null
>> > +_scratch_mkfs &>/dev/null
>>
>> Hi,
>>
>> Although I'm not the offical reviewer, but I think that stderr output can help us to find mkfs failure from golden image diff. So keep the stderr output maybe better.
>>
>> If you think your patch is necessary, you'd better give a appropriate reason to explain why we need to ignore that stderr output?
>>
>> Thanks,
>> Zorro
>
> mkfs succees with unexpected message when running generic/135, i.e.
> [root@localhost ~]# mkfs.ext4 /dev/sdb1 >/dev/null
> mke2fs 1.42.9 (28-Dec-2013)
Hi xiao,
Now I understand what you mean, and I can reproduce that problem. This
is a regression bug which bring in by commit:
4a5cda8 xfstests: do not unmount tmpfs during remount
That patch remove "2>&1". I think that is a miss, so you can simply bring
that back. After you explain the reason in your commit message clearly, I
think maintainer will glad to check it:)
Thanks,
Zorro
>
> thanks,
> xiao yang
>
>> > _scratch_mount
>> >
>> > cd $SCRATCH_MNT
>> > --
>> > 1.7.1
>> >
>> >
>> >
>> > --
>> > To unsubscribe from this list: send the line "unsubscribe fstests" in
>> > the body of a message to majordomo@vger.kernel.org
>> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next parent reply other threads:[~2016-02-22 9:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CADVQ27rD6UX7eechDFxke7aE=ty3NJJJKtKGsDR2sCVR5=EP=w@mail.gmail.com>
2016-02-22 9:40 ` Zirong Lang [this message]
2016-02-22 10:08 ` [PATCH] generic/135: fix standard error output from _scratch_mkfs Xiao Yang
2016-02-23 1:35 Xiao Yang
2016-02-23 3:26 ` Eryu Guan
2016-02-23 3:32 ` Theodore Ts'o
2016-03-02 5:45 ` Xiao Yang
-- strict thread matches above, loose matches on Subject: below --
2016-02-19 13:46 Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1578053095.20705983.1456134019296.JavaMail.zimbra@redhat.com \
--to=zlang@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.