From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 6/6] drm/i915: Cleanup properly if the implicit fence setup fails
Date: Fri, 10 Jan 2020 18:39:43 +0000 [thread overview]
Message-ID: <157868158326.10140.11983931839636055604@skylake-alporthouse-com> (raw)
In-Reply-To: <20200110183228.8199-6-ville.syrjala@linux.intel.com>
Quoting Ville Syrjala (2020-01-10 18:32:28)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We've already pinned the vma and fence by the time we try to
> deal with implicit fencing. Properly unpin the vma and fence
> if the fence setup fails instead of just bailing straight out
> from .prepare_fb(). As can be expected
> drm_atomic_helper_prepare_planes() will not call .cleanup_fb()
> for the plane whose .prepare_fb() failed so we must do the
> cleanup ourself.
>
> v2: Rebase
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-10 18:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 18:32 [Intel-gfx] [PATCH 1/6] drm/i915: Make a copy of the ggtt view for slave plane Ville Syrjala
2020-01-10 18:32 ` [Intel-gfx] [PATCH 2/6] drm/i915: Clear old hw.fb & co. from slave plane's state Ville Syrjala
2020-01-22 14:44 ` Maarten Lankhorst
2020-01-10 18:32 ` [Intel-gfx] [PATCH 3/6] drm/i915: Stop looking at plane->state in intel_prepare_plane_fb() Ville Syrjala
2020-01-10 20:10 ` Chris Wilson
2020-01-10 18:32 ` [Intel-gfx] [PATCH 4/6] drm/i915: s/intel_state/state/ in intel_{prepare, cleanup}_plane_fb() Ville Syrjala
2020-01-10 20:12 ` Chris Wilson
2020-01-10 18:32 ` [Intel-gfx] [PATCH 5/6] drm/i915: Balance prepare_fb/cleanup_fb Ville Syrjala
2020-01-10 18:42 ` Chris Wilson
2020-01-10 18:32 ` [Intel-gfx] [PATCH 6/6] drm/i915: Cleanup properly if the implicit fence setup fails Ville Syrjala
2020-01-10 18:39 ` Chris Wilson [this message]
2020-01-10 18:54 ` [Intel-gfx] [PATCH 1/6] drm/i915: Make a copy of the ggtt view for slave plane Chris Wilson
2020-01-13 13:15 ` Ville Syrjälä
2020-01-13 13:22 ` Chris Wilson
2020-01-10 21:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/6] " Patchwork
2020-01-13 14:54 ` [Intel-gfx] [PATCH 1/6] " Juha-Pekka Heikkila
2020-01-14 17:07 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/6] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157868158326.10140.11983931839636055604@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.