From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Jani Nikula" <jani.nikula@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH RESEND 1/6] drm/i915/dmc: use intel uncore functions for forcewake register access
Date: Thu, 23 Jan 2020 14:33:26 +0000 [thread overview]
Message-ID: <157979000636.19995.2361677609016844776@skylake-alporthouse-com> (raw)
In-Reply-To: <20200123141034.GS13686@intel.com>
Quoting Ville Syrjälä (2020-01-23 14:10:34)
> On Thu, Jan 23, 2020 at 03:59:59PM +0200, Jani Nikula wrote:
> > Move away from I915_READ_FW() and I915_WRITE_FW() and switch to using
> > intel_uncore_read_fw() and intel_uncore_write_fw(), respectively.
> >
> > No functional changes.
> >
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_csr.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> > index ae25960f74e0..6a408e11a3de 100644
> > --- a/drivers/gpu/drm/i915/intel_csr.c
> > +++ b/drivers/gpu/drm/i915/intel_csr.c
> > @@ -315,7 +315,8 @@ void intel_csr_load_program(struct drm_i915_private *dev_priv)
> > preempt_disable();
> >
> > for (i = 0; i < fw_size; i++)
> > - I915_WRITE_FW(CSR_PROGRAM(i), payload[i]);
> > + intel_uncore_write_fw(&dev_priv->uncore, CSR_PROGRAM(i),
> > + payload[i]);
>
> Why uncore instead of de?
Outside of display/
It might be very well worth moving intel_csr.c under the auspices of
display powermanagement.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-23 14:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 13:59 [Intel-gfx] [PATCH RESEND 1/6] drm/i915/dmc: use intel uncore functions for forcewake register access Jani Nikula
2020-01-23 14:00 ` [Intel-gfx] [PATCH RESEND 2/6] drm/i915/display: use intel de " Jani Nikula
2020-01-23 14:00 ` [Intel-gfx] [PATCH RESEND 3/6] drm/i915/irq: " Jani Nikula
2020-01-23 14:00 ` [Intel-gfx] [PATCH RESEND 4/6] drm/i915/gmbus: " Jani Nikula
2020-01-23 14:13 ` Ville Syrjälä
2020-01-23 14:00 ` [Intel-gfx] [PATCH RESEND 5/6] drm/i915/sprite: " Jani Nikula
2020-01-23 14:00 ` [Intel-gfx] [PATCH RESEND 6/6] drm/i915/pm: " Jani Nikula
2020-01-23 14:16 ` Ville Syrjälä
2020-01-23 14:34 ` Chris Wilson
2020-01-27 9:18 ` Jani Nikula
2020-01-23 14:10 ` [Intel-gfx] [PATCH RESEND 1/6] drm/i915/dmc: use intel uncore " Ville Syrjälä
2020-01-23 14:18 ` Jani Nikula
2020-01-23 14:33 ` Chris Wilson [this message]
2020-01-23 23:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [RESEND,1/6] " Patchwork
2020-01-23 23:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-01-25 15:30 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157979000636.19995.2361677609016844776@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.