From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Jani Nikula" <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: mass conversion to intel_de_*() register accessors
Date: Fri, 24 Jan 2020 18:26:15 -0000 [thread overview]
Message-ID: <157989037508.15091.6042031869306724995@emeril.freedesktop.org> (raw)
In-Reply-To: <cover.1579871655.git.jani.nikula@intel.com>
== Series Details ==
Series: drm/i915/display: mass conversion to intel_de_*() register accessors
URL : https://patchwork.freedesktop.org/series/72533/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
c07095a827f3 drm/i915/icl_dsi: use intel_de_*() functions for register access
36f2779671c5 drm/i915/audio: use intel_de_*() functions for register access
-:346: WARNING:LONG_LINE: line over 100 characters
#346: FILE: drivers/gpu/drm/i915/display/intel_audio.c:875:
+ (intel_de_read(dev_priv, AUD_PIN_BUF_CTL) | AUD_PIN_BUF_ENABLE));
total: 0 errors, 1 warnings, 0 checks, 306 lines checked
65fb0d418cb5 drm/i915/cdclk: use intel_de_*() functions for register access
-:62: WARNING:LONG_LINE: line over 100 characters
#62: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:241:
+ IS_PINEVIEW(dev_priv) || IS_MOBILE(dev_priv) ? HPLLVCO_MOBILE : HPLLVCO);
-:306: CHECK:CAMELCASE: Avoid CamelCase: <CNL_DSSM_CDCLK_PLL_REFCLK_24MHz>
#306: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1301:
+ if (intel_de_read(dev_priv, SKL_DSSM) & CNL_DSSM_CDCLK_PLL_REFCLK_24MHz)
-:447: ERROR:CODE_INDENT: code indent should use tabs where possible
#447: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:2553:
+^I^I DIV_ROUND_UP(dev_priv->cdclk.hw.cdclk, 1000));$
total: 1 errors, 1 warnings, 1 checks, 398 lines checked
e3e9bb668fb8 drm/i915/color: use intel_de_*() functions for register access
-:279: ERROR:CODE_INDENT: code indent should use tabs where possible
#279: FILE: drivers/gpu/drm/i915/display/intel_color.c:564:
+^I^I ilk_lut_10(&lut[i]));$
-:349: ERROR:CODE_INDENT: code indent should use tabs where possible
#349: FILE: drivers/gpu/drm/i915/display/intel_color.c:755:
+^I^I lut[i].green);$
total: 2 errors, 0 warnings, 0 checks, 419 lines checked
975fff8f273d drm/i915/combo_phy: use intel_de_*() functions for register access
d93abf166aae drm/i915/crt: use intel_de_*() functions for register access
-:95: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#95: FILE: drivers/gpu/drm/i915/display/intel_crt.c:445:
+ save_adpa = adpa = intel_de_read(dev_priv, crt->adpa_reg);
-:129: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#129: FILE: drivers/gpu/drm/i915/display/intel_crt.c:501:
+ save_adpa = adpa = intel_de_read(dev_priv, crt->adpa_reg);
-:206: WARNING:LONG_LINE: line over 100 characters
#206: FILE: drivers/gpu/drm/i915/display/intel_crt.c:983:
+ adpa | ADPA_DAC_ENABLE | ADPA_HSYNC_CNTL_DISABLE | ADPA_VSYNC_CNTL_DISABLE);
total: 0 errors, 1 warnings, 2 checks, 157 lines checked
3626a27aaf8e drm/i915/ddi: use intel_de_*() functions for register access
-:128: WARNING:LONG_LINE: line over 100 characters
#128: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:1168:
+ FDI_RX_PWRDN_LANE1_VAL(2) | FDI_RX_PWRDN_LANE0_VAL(2) | FDI_RX_TP1_TO_TP2_48 | FDI_RX_FDI_DELAY_90);
-:161: WARNING:LONG_LINE: line over 100 characters
#161: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:1192:
+ DP_TP_CTL_FDI_AUTOTRAIN | DP_TP_CTL_ENHANCED_FRAME_ENABLE | DP_TP_CTL_LINK_TRAIN_PAT1 | DP_TP_CTL_ENABLE);
-:173: WARNING:LONG_LINE: line over 100 characters
#173: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:1199:
+ DDI_BUF_CTL_ENABLE | ((crtc_state->fdi_lanes - 1) << 1) | DDI_BUF_TRANS_SELECT(i / 2));
-:256: WARNING:LONG_LINE: line over 100 characters
#256: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:1267:
+ DP_TP_CTL_FDI_AUTOTRAIN | DP_TP_CTL_LINK_TRAIN_NORMAL | DP_TP_CTL_ENHANCED_FRAME_ENABLE | DP_TP_CTL_ENABLE);
-:953: WARNING:LONG_LINE: line over 100 characters
#953: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:3211:
+ intel_de_read(dev_priv, DPCLKA_CFGCR0) | DPCLKA_CFGCR0_DDI_CLK_OFF(port));
total: 0 errors, 5 warnings, 0 checks, 1169 lines checked
dadca7367192 drm/i915/display: use intel_de_*() functions for register access
-:63: WARNING:LONG_LINE: line over 100 characters
#63: FILE: drivers/gpu/drm/i915/display/intel_display.c:522:
+ intel_de_read(dev_priv, CLKGATE_DIS_PSL(pipe)) | DUPS1_GATING_DIS | DUPS2_GATING_DIS);
-:63: ERROR:CODE_INDENT: code indent should use tabs where possible
#63: FILE: drivers/gpu/drm/i915/display/intel_display.c:522:
+^I^I intel_de_read(dev_priv, CLKGATE_DIS_PSL(pipe)) | DUPS1_GATING_DIS | DUPS2_GATING_DIS);$
-:69: WARNING:LONG_LINE: line over 100 characters
#69: FILE: drivers/gpu/drm/i915/display/intel_display.c:525:
+ intel_de_read(dev_priv, CLKGATE_DIS_PSL(pipe)) & ~(DUPS1_GATING_DIS | DUPS2_GATING_DIS));
-:69: ERROR:CODE_INDENT: code indent should use tabs where possible
#69: FILE: drivers/gpu/drm/i915/display/intel_display.c:525:
+^I^I intel_de_read(dev_priv, CLKGATE_DIS_PSL(pipe)) & ~(DUPS1_GATING_DIS | DUPS2_GATING_DIS));$
-:80: ERROR:CODE_INDENT: code indent should use tabs where possible
#80: FILE: drivers/gpu/drm/i915/display/intel_display.c:535:
+^I^I intel_de_read(dev_priv, CLKGATE_DIS_PSL(pipe)) | DPFR_GATING_DIS);$
-:85: ERROR:CODE_INDENT: code indent should use tabs where possible
#85: FILE: drivers/gpu/drm/i915/display/intel_display.c:538:
+^I^I intel_de_read(dev_priv, CLKGATE_DIS_PSL(pipe)) & ~DPFR_GATING_DIS);$
-:656: WARNING:LONG_LINE: line over 100 characters
#656: FILE: drivers/gpu/drm/i915/display/intel_display.c:5012:
+ intel_de_read(dev_priv, reg) | FDI_FS_ERRC_ENABLE | FDI_FE_ERRC_ENABLE);
-:656: ERROR:CODE_INDENT: code indent should use tabs where possible
#656: FILE: drivers/gpu/drm/i915/display/intel_display.c:5012:
+^I^I intel_de_read(dev_priv, reg) | FDI_FS_ERRC_ENABLE | FDI_FE_ERRC_ENABLE);$
-:1586: WARNING:LONG_LINE: line over 100 characters
#1586: FILE: drivers/gpu/drm/i915/display/intel_display.c:8242:
+ pipe_config->dpll_hw_state.dpll & ~(DPLL_VCO_ENABLE | DPLL_EXT_BUFFER_ENABLE_VLV));
-:1627: ERROR:CODE_INDENT: code indent should use tabs where possible
#1627: FILE: drivers/gpu/drm/i915/display/intel_display.c:8643:
+^I^I vsyncshift);$
-:1630: WARNING:LONG_LINE: line over 100 characters
#1630: FILE: drivers/gpu/drm/i915/display/intel_display.c:8646:
+ (adjusted_mode->crtc_hdisplay - 1) | ((adjusted_mode->crtc_htotal - 1) << 16));
-:1632: WARNING:LONG_LINE: line over 100 characters
#1632: FILE: drivers/gpu/drm/i915/display/intel_display.c:8648:
+ (adjusted_mode->crtc_hblank_start - 1) | ((adjusted_mode->crtc_hblank_end - 1) << 16));
-:1634: WARNING:LONG_LINE: line over 100 characters
#1634: FILE: drivers/gpu/drm/i915/display/intel_display.c:8650:
+ (adjusted_mode->crtc_hsync_start - 1) | ((adjusted_mode->crtc_hsync_end - 1) << 16));
-:1641: WARNING:LONG_LINE: line over 100 characters
#1641: FILE: drivers/gpu/drm/i915/display/intel_display.c:8657:
+ (adjusted_mode->crtc_vsync_start - 1) | ((adjusted_mode->crtc_vsync_end - 1) << 16));
-:1651: ERROR:CODE_INDENT: code indent should use tabs where possible
#1651: FILE: drivers/gpu/drm/i915/display/intel_display.c:8666:
+^I^I intel_de_read(dev_priv, VTOTAL(cpu_transcoder)));$
-:1672: WARNING:LONG_LINE: line over 100 characters
#1672: FILE: drivers/gpu/drm/i915/display/intel_display.c:8693:
+ return intel_de_read(dev_priv, PIPECONF(cpu_transcoder)) & PIPECONF_INTERLACE_MASK_HSW;
-:2078: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2078: FILE: drivers/gpu/drm/i915/display/intel_display.c:10235:
+ m2_n2->link_n = intel_de_read(dev_priv,
+ PIPE_LINK_N2(transcoder));
-:2080: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2080: FILE: drivers/gpu/drm/i915/display/intel_display.c:10237:
+ m2_n2->gmch_m = intel_de_read(dev_priv,
+ PIPE_DATA_M2(transcoder))
-:2085: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2085: FILE: drivers/gpu/drm/i915/display/intel_display.c:10240:
+ m2_n2->gmch_n = intel_de_read(dev_priv,
+ PIPE_DATA_N2(transcoder));
-:2325: ERROR:CODE_INDENT: code indent should use tabs where possible
#2325: FILE: drivers/gpu/drm/i915/display/intel_display.c:10946:
+^I^I^I^I TRANS_DDI_FUNC_CTL2(cpu_transcoder));$
-:2325: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2325: FILE: drivers/gpu/drm/i915/display/intel_display.c:10946:
+ trans_port_sync = intel_de_read(dev_priv,
+ TRANS_DDI_FUNC_CTL2(cpu_transcoder));
-:2464: CHECK:CAMELCASE: Avoid CamelCase: <ILK_eDP_A_DISABLE>
#2464: FILE: drivers/gpu/drm/i915/display/intel_display.c:16612:
+ if (IS_GEN(dev_priv, 5) && (intel_de_read(dev_priv, FUSE_STRAP) & ILK_eDP_A_DISABLE))
total: 8 errors, 9 warnings, 5 checks, 2683 lines checked
9129d0adc87c drm/i915/display_power: use intel_de_*() functions for register access
-:312: WARNING:LONG_LINE: line over 100 characters
#312: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:944:
+ intel_de_read(dev_priv, GEN8_CHICKEN_DCPR_1) | SKL_SELECT_ALTERNATE_DC_EXIT);
-:334: WARNING:LONG_LINE: line over 100 characters
#334: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:968:
+ intel_de_read(dev_priv, GEN8_CHICKEN_DCPR_1) | SKL_SELECT_ALTERNATE_DC_EXIT);
total: 0 errors, 2 warnings, 0 checks, 734 lines checked
f827549283b1 drm/i915/dp: use intel_de_*() functions for register access
-:710: WARNING:LONG_LINE: line over 100 characters
#710: FILE: drivers/gpu/drm/i915/display/intel_dp.c:6917:
+ REG_FIELD_PREP(PP_REFERENCE_DIVIDER_MASK, (100 * div) / 2 - 1) | REG_FIELD_PREP(PANEL_POWER_CYCLE_DELAY_MASK, DIV_ROUND_UP(seq->t11_t12, 1000)));
-:769: WARNING:LINE_SPACING: Missing a blank line after declarations
#769: FILE: drivers/gpu/drm/i915/display/intel_dp.c:7560:
+ u32 temp = intel_de_read(dev_priv, PEG_BAND_GAP_DATA);
+ intel_de_write(dev_priv, PEG_BAND_GAP_DATA,
total: 0 errors, 2 warnings, 0 checks, 660 lines checked
59d4feee81b6 drm/i915/dpio_phy: use intel_de_*() functions for register access
dac3c1307ff6 drm/i915/dpll_mgr: use intel_de_*() functions for register access
62cb010d54e3 drm/i915/dp_mst: use intel_de_*() functions for register access
6351092052d2 drm/i915/dsb: use intel_de_*() functions for register access
6b856ed292fb drm/i915/dvo: use intel_de_*() functions for register access
-:131: WARNING:LONG_LINE: line over 100 characters
#131: FILE: drivers/gpu/drm/i915/display/intel_dvo.c:305:
+ (adjusted_mode->crtc_hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) | (adjusted_mode->crtc_vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));
total: 0 errors, 1 warnings, 0 checks, 96 lines checked
46415f31fdbe drm/i915/fbc: use intel_de_*() functions for register access
-:263: WARNING:LONG_LINE: line over 100 characters
#263: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:338:
+ intel_de_read(dev_priv, CHICKEN_PIPESL_1(params->crtc.pipe)) | HSW_FBCQ_DIS);
-:312: ERROR:CODE_INDENT: code indent should use tabs where possible
#312: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:1371:
+^I^I 500 << FBC_CTL_INTERVAL_SHIFT);$
total: 1 errors, 1 warnings, 0 checks, 247 lines checked
f6f92e9ec996 drm/i915/fifo_underrun: use intel_de_*() functions for register access
fd2ac1b92db5 drm/i915/gmbus: use intel_de_*() functions for register access
-:164: WARNING:LONG_LINE: line over 100 characters
#164: FILE: drivers/gpu/drm/i915/display/intel_gmbus.c:414:
+ gmbus1_index | GMBUS_CYCLE_WAIT | (size << GMBUS_BYTE_COUNT_SHIFT) | (addr << GMBUS_SLAVE_ADDR_SHIFT) | GMBUS_SLAVE_READ | GMBUS_SW_RDY);
-:198: WARNING:LONG_LINE: line over 100 characters
#198: FILE: drivers/gpu/drm/i915/display/intel_gmbus.c:493:
+ gmbus1_index | GMBUS_CYCLE_WAIT | (chunk_size << GMBUS_BYTE_COUNT_SHIFT) | (addr << GMBUS_SLAVE_ADDR_SHIFT) | GMBUS_SLAVE_WRITE | GMBUS_SW_RDY);
total: 0 errors, 2 warnings, 0 checks, 205 lines checked
3525b2857c38 drm/i915/hdcp: use intel_de_*() functions for register access
-:60: ERROR:CODE_INDENT: code indent should use tabs where possible
#60: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:116:
+^I HDCP_STATUS(dev_priv, cpu_transcoder, port)) &$
-:70: ERROR:CODE_INDENT: code indent should use tabs where possible
#70: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:125:
+^I HDCP2_STATUS(dev_priv, cpu_transcoder, port)) &$
-:83: WARNING:LONG_LINE: line over 100 characters
#83: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:191:
+ HDCP_KEY_LOAD_DONE | HDCP_KEY_LOAD_STATUS | HDCP_FUSE_IN_PROGRESS | HDCP_FUSE_ERROR | HDCP_FUSE_DONE);
-:435: WARNING:LONG_LINE: line over 100 characters
#435: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:1565:
+ intel_de_read(dev_priv, HDCP2_CTL(dev_priv, cpu_transcoder, port)) | CTL_LINK_ENCRYPTION_REQ);
-:451: WARNING:LONG_LINE: line over 100 characters
#451: FILE: drivers/gpu/drm/i915/display/intel_hdcp.c:1590:
+ intel_de_read(dev_priv, HDCP2_CTL(dev_priv, cpu_transcoder, port)) & ~CTL_LINK_ENCRYPTION_REQ);
total: 2 errors, 3 warnings, 0 checks, 380 lines checked
3841cf8aa830 drm/i915/hdmi: use intel_de_*() functions for register access
-:323: ERROR:CODE_INDENT: code indent should use tabs where possible
#323: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:495:
+^I^I^I^I VLV_TVIDEO_DIP_DATA(crtc->pipe));$
-:386: ERROR:CODE_INDENT: code indent should use tabs where possible
#386: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:567:
+^I^I^I^I hsw_dip_data_reg(dev_priv, cpu_transcoder, type, i >> 2));$
-:668: ERROR:CODE_INDENT: code indent should use tabs where possible
#668: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:1936:
+^I^I temp & ~SDVO_ENABLE);$
-:703: WARNING:LONG_LINE: line over 100 characters
#703: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:1982:
+ intel_de_read(dev_priv, TRANS_CHICKEN1(pipe)) | TRANS_CHICKEN1_HDMIUNIT_GC_DISABLE);
-:703: ERROR:CODE_INDENT: code indent should use tabs where possible
#703: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:1982:
+^I^I intel_de_read(dev_priv, TRANS_CHICKEN1(pipe)) | TRANS_CHICKEN1_HDMIUNIT_GC_DISABLE);$
-:727: WARNING:LONG_LINE: line over 100 characters
#727: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:1999:
+ intel_de_read(dev_priv, TRANS_CHICKEN1(pipe)) & ~TRANS_CHICKEN1_HDMIUNIT_GC_DISABLE);
-:727: ERROR:CODE_INDENT: code indent should use tabs where possible
#727: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:1999:
+^I^I intel_de_read(dev_priv, TRANS_CHICKEN1(pipe)) & ~TRANS_CHICKEN1_HDMIUNIT_GC_DISABLE);$
-:774: WARNING:LINE_SPACING: Missing a blank line after declarations
#774: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:3201:
+ u32 temp = intel_de_read(dev_priv, PEG_BAND_GAP_DATA);
+ intel_de_write(dev_priv, PEG_BAND_GAP_DATA,
-:775: ERROR:CODE_INDENT: code indent should use tabs where possible
#775: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:3202:
+^I^I (temp & ~0xf) | 0xd);$
total: 6 errors, 3 warnings, 0 checks, 677 lines checked
38949463942f drm/i915/lpe_audio: use intel_de_*() functions for register access
fa2af54524c8 drm/i915/lvds: use intel_de_*() functions for register access
-:121: WARNING:LONG_LINE: line over 100 characters
#121: FILE: drivers/gpu/drm/i915/display/intel_lvds.c:213:
+ REG_FIELD_PREP(PANEL_PORT_SELECT_MASK, pps->port) | REG_FIELD_PREP(PANEL_POWER_UP_DELAY_MASK, pps->t1_t2) | REG_FIELD_PREP(PANEL_LIGHT_ON_DELAY_MASK, pps->t5));
-:127: WARNING:LONG_LINE: line over 100 characters
#127: FILE: drivers/gpu/drm/i915/display/intel_lvds.c:216:
+ REG_FIELD_PREP(PANEL_POWER_DOWN_DELAY_MASK, pps->t3) | REG_FIELD_PREP(PANEL_LIGHT_OFF_DELAY_MASK, pps->tx));
-:134: WARNING:LONG_LINE: line over 100 characters
#134: FILE: drivers/gpu/drm/i915/display/intel_lvds.c:219:
+ REG_FIELD_PREP(PP_REFERENCE_DIVIDER_MASK, pps->divider) | REG_FIELD_PREP(PANEL_POWER_CYCLE_DELAY_MASK, DIV_ROUND_UP(pps->t4, 1000) + 1));
total: 0 errors, 3 warnings, 0 checks, 135 lines checked
33568867e120 drm/i915/overlay: use intel_de_*() functions for register access
70abf854e570 drm/i915/panel: use intel_de_*() functions for register access
-:107: WARNING:LINE_SPACING: Missing a blank line after declarations
#107: FILE: drivers/gpu/drm/i915/display/intel_panel.c:610:
+ u32 val = intel_de_read(dev_priv, BLC_PWM_PCH_CTL2) & ~BACKLIGHT_DUTY_CYCLE_MASK;
+ intel_de_write(dev_priv, BLC_PWM_PCH_CTL2, val | level);
total: 0 errors, 1 warnings, 0 checks, 609 lines checked
5a5f3f5ef651 drm/i915/pipe_crc: use intel_de_*() functions for register access
406166f74cf9 drm/i915/psr: use intel_de_*() functions for register access
-:158: WARNING:LONG_LINE: line over 100 characters
#158: FILE: drivers/gpu/drm/i915/display/intel_psr.c:740:
+ WARN_ON(intel_de_read(dev_priv, EDP_PSR2_CTL(dev_priv->psr.transcoder)) & EDP_PSR2_ENABLE);
total: 0 errors, 1 warnings, 0 checks, 183 lines checked
e4aa567631f4 drm/i915/sdvo: use intel_de_*() functions for register access
c3ae7ea81350 drm/i915/sprite: use intel_de_*() functions for register access
-:188: WARNING:LONG_LINE: line over 100 characters
#188: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:670:
+ (plane_state->color_plane[1].y << 16) | plane_state->color_plane[1].x);
total: 0 errors, 1 warnings, 0 checks, 510 lines checked
afa64a3c6bbd drm/i915/tv: use intel_de_*() functions for register access
-:206: WARNING:LONG_LINE: line over 100 characters
#206: FILE: drivers/gpu/drm/i915/display/intel_tv.c:1529:
+ ((video_levels->black << TV_BLACK_LEVEL_SHIFT) | (video_levels->blank << TV_BLANK_LEVEL_SHIFT)));
-:259: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#259: FILE: drivers/gpu/drm/i915/display/intel_tv.c:1590:
+ save_tv_dac = tv_dac = intel_de_read(dev_priv, TV_DAC);
-:260: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#260: FILE: drivers/gpu/drm/i915/display/intel_tv.c:1591:
+ save_tv_ctl = tv_ctl = intel_de_read(dev_priv, TV_CTL);
total: 0 errors, 1 warnings, 2 checks, 257 lines checked
12c70fe8b613 drm/i915/vdsc: use intel_de_*() functions for register access
f3b543cd4384 drm/i915/vga: use intel_de_*() functions for register access
cdbe7f57017f drm/i915/vlv_dsi: use intel_de_*() functions for register access
-:529: ERROR:CODE_INDENT: code indent should use tabs where possible
#529: FILE: drivers/gpu/drm/i915/display/vlv_dsi.c:1085:
+^I^I^I^I BXT_MIPI_TRANS_HACTIVE(port));$
-:533: ERROR:CODE_INDENT: code indent should use tabs where possible
#533: FILE: drivers/gpu/drm/i915/display/vlv_dsi.c:1088:
+^I^I^I^I BXT_MIPI_TRANS_VACTIVE(port));$
-:537: ERROR:CODE_INDENT: code indent should use tabs where possible
#537: FILE: drivers/gpu/drm/i915/display/vlv_dsi.c:1091:
+^I^I^I^I BXT_MIPI_TRANS_VTOTAL(port));$
-:656: WARNING:LONG_LINE: line over 100 characters
#656: FILE: drivers/gpu/drm/i915/display/vlv_dsi.c:1389:
+ adjusted_mode->crtc_vdisplay << VERTICAL_ADDRESS_SHIFT | mode_hdisplay << HORIZONTAL_ADDRESS_SHIFT);
-:678: WARNING:LONG_LINE: line over 100 characters
#678: FILE: drivers/gpu/drm/i915/display/vlv_dsi.c:1438:
+ txbyteclkhs(adjusted_mode->crtc_htotal, bpp, intel_dsi->lane_count, intel_dsi->burst_mode_ratio) + 1);
-:686: WARNING:LONG_LINE: line over 100 characters
#686: FILE: drivers/gpu/drm/i915/display/vlv_dsi.c:1441:
+ txbyteclkhs(adjusted_mode->crtc_vtotal * adjusted_mode->crtc_htotal, bpp, intel_dsi->lane_count, intel_dsi->burst_mode_ratio) + 1);
-:776: WARNING:LONG_LINE: line over 100 characters
#776: FILE: drivers/gpu/drm/i915/display/vlv_dsi.c:1509:
+ intel_dsi->clk_lp_to_hs_count << LP_HS_SSW_CNT_SHIFT | intel_dsi->clk_hs_to_lp_count << HS_LP_PWR_SW_CNT_SHIFT);
-:788: WARNING:LONG_LINE: line over 100 characters
#788: FILE: drivers/gpu/drm/i915/display/vlv_dsi.c:1516:
+ intel_dsi->video_frmt_cfg_bits | intel_dsi->video_mode_format | IP_TG_CONFIG | RANDOM_DPI_DISPLAY_RESOLUTION);
total: 3 errors, 5 warnings, 0 checks, 733 lines checked
913f16a2e7ae drm/i915/vlv_dsi_pll: use intel_de_*() functions for register access
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-24 18:26 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 13:25 [Intel-gfx] [RFC 00/33] drm/i915/display: mass conversion to intel_de_*() register accessors Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 01/33] drm/i915/icl_dsi: use intel_de_*() functions for register access Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 02/33] drm/i915/audio: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 03/33] drm/i915/cdclk: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 04/33] drm/i915/color: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 05/33] drm/i915/combo_phy: " Jani Nikula
2020-01-24 21:30 ` Matt Roper
2020-01-27 18:19 ` Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 06/33] drm/i915/crt: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 07/33] drm/i915/ddi: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 08/33] drm/i915/display: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 09/33] drm/i915/display_power: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 10/33] drm/i915/dp: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 11/33] drm/i915/dpio_phy: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 12/33] drm/i915/dpll_mgr: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 13/33] drm/i915/dp_mst: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 14/33] drm/i915/dsb: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 15/33] drm/i915/dvo: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 16/33] drm/i915/fbc: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 17/33] drm/i915/fifo_underrun: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 18/33] drm/i915/gmbus: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 19/33] drm/i915/hdcp: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 20/33] drm/i915/hdmi: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 21/33] drm/i915/lpe_audio: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 22/33] drm/i915/lvds: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 23/33] drm/i915/overlay: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 24/33] drm/i915/panel: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 25/33] drm/i915/pipe_crc: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 26/33] drm/i915/psr: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 27/33] drm/i915/sdvo: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 28/33] drm/i915/sprite: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 29/33] drm/i915/tv: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 30/33] drm/i915/vdsc: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 31/33] drm/i915/vga: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 32/33] drm/i915/vlv_dsi: " Jani Nikula
2020-01-24 13:25 ` [Intel-gfx] [RFC 33/33] drm/i915/vlv_dsi_pll: " Jani Nikula
2020-01-24 13:54 ` [Intel-gfx] [RFC 00/33] drm/i915/display: mass conversion to intel_de_*() register accessors Chris Wilson
2020-01-24 22:30 ` Rodrigo Vivi
2020-01-25 14:55 ` Jani Nikula
2020-01-27 18:10 ` Jani Nikula
2020-01-24 18:26 ` Patchwork [this message]
2020-01-24 18:34 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2020-01-24 18:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-01-24 21:35 ` [Intel-gfx] [RFC 00/33] " Matt Roper
2020-01-27 18:29 ` Jani Nikula
2020-01-27 0:43 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2020-01-27 13:48 ` [Intel-gfx] [RFC 00/33] " Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157989037508.15091.6042031869306724995@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.