From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: sandeen@sandeen.net, darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 03/18] libxfs: remove LIBXFS_EXIT_ON_FAILURE
Date: Wed, 19 Feb 2020 17:42:52 -0800 [thread overview]
Message-ID: <158216297243.602314.7156693497979033081.stgit@magnolia> (raw)
In-Reply-To: <158216295405.602314.2094526611933874427.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
Now that all the implicit users of this flag are gone, remove its
definition.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
include/libxfs.h | 1 -
libxfs/libxfs_io.h | 2 +-
libxfs/rdwr.c | 2 +-
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/libxfs.h b/include/libxfs.h
index aaac00f6..14113e56 100644
--- a/include/libxfs.h
+++ b/include/libxfs.h
@@ -126,7 +126,6 @@ typedef struct libxfs_xinit {
int bcache_flags; /* cache init flags */
} libxfs_init_t;
-#define LIBXFS_EXIT_ON_FAILURE 0x0001 /* exit the program if a call fails */
#define LIBXFS_ISREADONLY 0x0002 /* disallow all mounted filesystems */
#define LIBXFS_ISINACTIVE 0x0004 /* allow mounted only if mounted ro */
#define LIBXFS_DANGEROUSLY 0x0008 /* repairing a device mounted ro */
diff --git a/libxfs/libxfs_io.h b/libxfs/libxfs_io.h
index bb6b689e..560cf0fd 100644
--- a/libxfs/libxfs_io.h
+++ b/libxfs/libxfs_io.h
@@ -86,7 +86,7 @@ bool xfs_verify_magic(struct xfs_buf *bp, __be32 dmagic);
bool xfs_verify_magic16(struct xfs_buf *bp, __be16 dmagic);
/* b_flags bits */
-#define LIBXFS_B_EXIT 0x0001 /* ==LIBXFS_EXIT_ON_FAILURE */
+#define LIBXFS_B_EXIT 0x0001 /* exit if write fails */
#define LIBXFS_B_DIRTY 0x0002 /* buffer has been modified */
#define LIBXFS_B_STALE 0x0004 /* buffer marked as invalid */
#define LIBXFS_B_UPTODATE 0x0008 /* buffer is sync'd to disk */
diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
index f56303e2..6a75fb12 100644
--- a/libxfs/rdwr.c
+++ b/libxfs/rdwr.c
@@ -19,7 +19,7 @@
#include "xfs_trans.h"
#include "libfrog/platform.h"
-#include "libxfs.h" /* for LIBXFS_EXIT_ON_FAILURE */
+#include "libxfs.h"
/*
* Important design/architecture note:
next prev parent reply other threads:[~2020-02-20 1:42 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 1:42 [PATCH 00/18] xfsprogs: refactor buffer function names Darrick J. Wong
2020-02-20 1:42 ` [PATCH 01/18] libxfs: clean up readbuf flags Darrick J. Wong
2020-02-21 14:42 ` Christoph Hellwig
2020-02-21 15:55 ` Darrick J. Wong
2020-02-20 1:42 ` [PATCH 02/18] libxfs: clean up writebuf flags Darrick J. Wong
2020-02-20 1:42 ` Darrick J. Wong [this message]
2020-02-20 1:43 ` [PATCH 04/18] libxfs: replace libxfs_putbuf with libxfs_buf_relse Darrick J. Wong
2020-02-21 14:43 ` Christoph Hellwig
2020-02-21 15:01 ` Eric Sandeen
2020-02-20 1:43 ` [PATCH 05/18] libxfs: replace libxfs_getbuf with libxfs_buf_get Darrick J. Wong
2020-02-21 14:43 ` Christoph Hellwig
2020-02-20 1:43 ` [PATCH 06/18] libxfs: replace libxfs_readbuf with libxfs_buf_read Darrick J. Wong
2020-02-21 14:44 ` Christoph Hellwig
2020-02-20 1:43 ` [PATCH 07/18] libxfs: make libxfs_bwrite do what libxfs_writebufr does Darrick J. Wong
2020-02-21 14:45 ` Christoph Hellwig
2020-02-21 20:43 ` Darrick J. Wong
2020-02-20 1:43 ` [PATCH 08/18] libxfs: make libxfs_readbuf_verify return an error code Darrick J. Wong
2020-02-21 14:46 ` Christoph Hellwig
2020-02-20 1:43 ` [PATCH 09/18] libxfs: make libxfs_readbufr stash the error value in b_error Darrick J. Wong
2020-02-21 14:46 ` Christoph Hellwig
2020-02-20 1:43 ` [PATCH 10/18] libxfs: introduce libxfs_buf_read_uncached Darrick J. Wong
2020-02-21 14:48 ` Christoph Hellwig
2020-02-21 20:50 ` Darrick J. Wong
2020-02-21 20:59 ` Darrick J. Wong
2020-02-20 1:43 ` [PATCH 11/18] libxlog: use uncached buffers instead of open-coding them Darrick J. Wong
2020-02-21 14:49 ` Christoph Hellwig
2020-02-21 15:51 ` Darrick J. Wong
2020-02-20 1:43 ` [PATCH 12/18] libxfs: use uncached buffers for initial mkfs writes Darrick J. Wong
2020-02-21 14:51 ` Christoph Hellwig
2020-02-21 15:52 ` Darrick J. Wong
2020-02-20 1:43 ` [PATCH 13/18] libxfs: straighten out libxfs_writebuf confusion Darrick J. Wong
2020-02-21 14:53 ` Christoph Hellwig
2020-02-21 15:54 ` Darrick J. Wong
2020-02-20 1:44 ` [PATCH 14/18] libxfs: remove libxfs_writebuf_int Darrick J. Wong
2020-02-21 14:53 ` Christoph Hellwig
2020-02-20 1:44 ` [PATCH 15/18] libxfs: hide libxfs_{get,put}bufr Darrick J. Wong
2020-02-21 14:53 ` Christoph Hellwig
2020-02-21 16:00 ` Darrick J. Wong
2020-02-20 1:44 ` [PATCH 16/18] libxfs: hide libxfs_getbuf_flags Darrick J. Wong
2020-02-21 14:54 ` Christoph Hellwig
2020-02-20 1:44 ` [PATCH 17/18] libxfs: rename libxfs_readbuf_map to libxfs_buf_read_map Darrick J. Wong
2020-02-21 14:54 ` Christoph Hellwig
2020-02-20 1:44 ` [PATCH 18/18] libxfs: rename libxfs_getbuf_map to libxfs_buf_get_map Darrick J. Wong
2020-02-21 14:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158216297243.602314.7156693497979033081.stgit@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.