All of lore.kernel.org
 help / color / mirror / Atom feed
From: "tip-bot2 for Michal Simek" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Michal Simek <michal.simek@xilinx.com>,
	Marc Zyngier <maz@kernel.org>,
	Stefan Asserhall <stefan.asserhall@xilinx.com>,
	x86 <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [tip: irq/core] irqchip/xilinx: Fill error code when irq domain registration fails
Date: Sun, 29 Mar 2020 20:26:11 -0000	[thread overview]
Message-ID: <158551357125.28353.14243002761268594399.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20200317125600.15913-3-mubin.usman.sayyed@xilinx.com>

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     c74038baa9bccac76344b7215a55be136c81dfc3
Gitweb:        https://git.kernel.org/tip/c74038baa9bccac76344b7215a55be136c81dfc3
Author:        Michal Simek <michal.simek@xilinx.com>
AuthorDate:    Tue, 17 Mar 2020 18:25:58 +05:30
Committer:     Marc Zyngier <maz@kernel.org>
CommitterDate: Sun, 22 Mar 2020 11:52:53 

irqchip/xilinx: Fill error code when irq domain registration fails

There is no ret filled in case of irq_domain_add_linear() failure.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Stefan Asserhall <stefan.asserhall@xilinx.com>
Link: https://lore.kernel.org/r/20200317125600.15913-3-mubin.usman.sayyed@xilinx.com
---
 drivers/irqchip/irq-xilinx-intc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-xilinx-intc.c b/drivers/irqchip/irq-xilinx-intc.c
index 34593fa..1d3d273 100644
--- a/drivers/irqchip/irq-xilinx-intc.c
+++ b/drivers/irqchip/irq-xilinx-intc.c
@@ -228,6 +228,7 @@ static int __init xilinx_intc_of_init(struct device_node *intc,
 						  &xintc_irq_domain_ops, irqc);
 	if (!irqc->root_domain) {
 		pr_err("irq-xilinx: Unable to create IRQ domain\n");
+		ret = -EINVAL;
 		goto error;
 	}
 

  reply	other threads:[~2020-03-29 20:26 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-17 12:55 [PATCH v5 0/4] irqchip: xilinx: Add support for multiple instances Mubin Usman Sayyed
2020-03-17 12:55 ` Mubin Usman Sayyed
2020-03-17 12:55 ` [PATCH v5 1/4] " Mubin Usman Sayyed
2020-03-17 12:55   ` Mubin Usman Sayyed
2020-03-29 20:26   ` [tip: irq/core] irqchip/xilinx: " tip-bot2 for Mubin Sayyed
2020-03-17 12:55 ` [PATCH v5 2/4] irqchip: xilinx: Fill error code when irq domain registration fails Mubin Usman Sayyed
2020-03-17 12:55   ` Mubin Usman Sayyed
2020-03-29 20:26   ` tip-bot2 for Michal Simek [this message]
2020-03-17 12:55 ` [PATCH v5 3/4] irqchip: xilinx: Enable generic irq multi handler Mubin Usman Sayyed
2020-03-17 12:55   ` Mubin Usman Sayyed
2020-03-29 20:26   ` [tip: irq/core] irqchip/xilinx: " tip-bot2 for Michal Simek
2020-03-30  8:32     ` Michal Simek
2020-03-30  8:45       ` Marc Zyngier
2020-03-30  9:03         ` Michal Simek
2020-03-30  9:12           ` Michal Simek
2020-03-30  9:19             ` Marc Zyngier
2020-03-30  9:27               ` Michal Simek
2020-03-30 10:04                 ` Marc Zyngier
2020-03-30 10:12                   ` Michal Simek
2020-03-31 20:47                   ` Stephen Rothwell
2020-04-01 11:05                 ` [tip: irq/urgent] Revert "irqchip/xilinx: Enable generic irq multi handler" tip-bot2 for Marc Zyngier
2020-04-01 11:05                 ` [tip: irq/urgent] Revert "irqchip/xilinx: Do not call irq_set_default_host()" tip-bot2 for Marc Zyngier
2020-03-30  9:14           ` [tip: irq/core] irqchip/xilinx: Enable generic irq multi handler Marc Zyngier
2020-03-30  9:18             ` Michal Simek
2020-03-17 12:56 ` [PATCH v5 4/4] irqchip: xilinx: Do not call irq_set_default_host() Mubin Usman Sayyed
2020-03-17 12:56   ` Mubin Usman Sayyed
2020-03-29 20:26   ` [tip: irq/core] irqchip/xilinx: " tip-bot2 for Mubin Sayyed
2020-03-21 15:19 ` [PATCH v5 0/4] irqchip: xilinx: Add support for multiple instances Marc Zyngier
2020-03-21 15:19   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=158551357125.28353.14243002761268594399.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=stefan.asserhall@xilinx.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.