All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 10/19] xfs: refactor log recovery quotaoff item dispatch for pass2 commit functions
Date: Tue, 21 Apr 2020 19:07:06 -0700	[thread overview]
Message-ID: <158752122672.2140829.3691203963610665663.stgit@magnolia> (raw)
In-Reply-To: <158752116283.2140829.12265815455525398097.stgit@magnolia>

From: Darrick J. Wong <darrick.wong@oracle.com>

Move the log quotaoff item pass2 commit code into the per-item source code
files and use the dispatch function to call it.  We do these one at a
time because there's a lot of code to move.  No functional changes.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/xfs/xfs_log_recover.c |   14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)


diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
index 18b797ca4a6c..5e7e5c66327e 100644
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -2502,20 +2502,16 @@ xlog_recover_commit_pass2(
 {
 	trace_xfs_log_recover_item_recover(log, trans, item, XLOG_RECOVER_PASS2);
 
-	if (item->ri_type && item->ri_type->commit_pass2_fn)
-		return item->ri_type->commit_pass2_fn(log, buffer_list, item,
-				trans->r_lsn);
-
-	switch (ITEM_TYPE(item)) {
-	case XFS_LI_QUOTAOFF:
-		/* nothing to do in pass2 */
-		return 0;
-	default:
+	if (!item->ri_type) {
 		xfs_warn(log->l_mp, "%s: invalid item type (%d)",
 			__func__, ITEM_TYPE(item));
 		ASSERT(0);
 		return -EFSCORRUPTED;
 	}
+	if (!item->ri_type->commit_pass2_fn)
+		return 0;
+	return item->ri_type->commit_pass2_fn(log, buffer_list, item,
+			trans->r_lsn);
 }
 
 STATIC int


  parent reply	other threads:[~2020-04-22  2:07 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22  2:06 [PATCH 00/19] xfs: refactor log recovery Darrick J. Wong
2020-04-22  2:06 ` [PATCH 01/19] xfs: complain when we don't recognize the log item type Darrick J. Wong
2020-04-22 16:17   ` Brian Foster
2020-04-25 17:42   ` Christoph Hellwig
2020-04-27 17:55     ` Darrick J. Wong
2020-04-22  2:06 ` [PATCH 02/19] xfs: refactor log recovery item sorting into a generic dispatch structure Darrick J. Wong
2020-04-25 18:13   ` Christoph Hellwig
2020-04-27 22:04     ` Darrick J. Wong
2020-04-28  5:11       ` Christoph Hellwig
2020-04-28 20:46         ` Darrick J. Wong
2020-04-22  2:06 ` [PATCH 03/19] xfs: refactor log recovery item dispatch for pass2 readhead functions Darrick J. Wong
2020-04-25 18:19   ` Christoph Hellwig
2020-04-28 20:54     ` Darrick J. Wong
2020-04-29  6:07       ` Christoph Hellwig
2020-04-22  2:06 ` [PATCH 04/19] xfs: refactor log recovery item dispatch for pass1 commit functions Darrick J. Wong
2020-04-25 18:20   ` Christoph Hellwig
2020-04-22  2:06 ` [PATCH 05/19] xfs: refactor log recovery buffer item dispatch for pass2 " Darrick J. Wong
2020-04-22  2:06 ` [PATCH 06/19] xfs: refactor log recovery inode " Darrick J. Wong
2020-04-22  2:06 ` [PATCH 07/19] xfs: refactor log recovery intent " Darrick J. Wong
2020-04-25 18:24   ` Christoph Hellwig
2020-04-28 22:42     ` Darrick J. Wong
2020-04-22  2:06 ` [PATCH 08/19] xfs: refactor log recovery dquot " Darrick J. Wong
2020-04-22  2:07 ` [PATCH 09/19] xfs: refactor log recovery icreate " Darrick J. Wong
2020-04-22  2:07 ` Darrick J. Wong [this message]
2020-04-22  2:07 ` [PATCH 11/19] xfs: refactor EFI log item recovery dispatch Darrick J. Wong
2020-04-25 18:28   ` Christoph Hellwig
2020-04-28 22:41     ` Darrick J. Wong
2020-04-28 23:45       ` Darrick J. Wong
2020-04-29  7:09         ` Christoph Hellwig
2020-04-29  7:18           ` Christoph Hellwig
2020-04-29 14:20           ` Darrick J. Wong
2020-04-22  2:07 ` [PATCH 12/19] xfs: refactor RUI " Darrick J. Wong
2020-04-25 18:28   ` Christoph Hellwig
2020-04-28 22:40     ` Darrick J. Wong
2020-04-22  2:07 ` [PATCH 13/19] xfs: refactor CUI " Darrick J. Wong
2020-04-22  2:07 ` [PATCH 14/19] xfs: refactor BUI " Darrick J. Wong
2020-04-22  2:07 ` [PATCH 15/19] xfs: refactor releasing finished intents during log recovery Darrick J. Wong
2020-04-25 18:34   ` Christoph Hellwig
2020-04-28 22:40     ` Darrick J. Wong
2020-04-22  2:07 ` [PATCH 16/19] xfs: refactor adding recovered intent items to the log Darrick J. Wong
2020-04-25 18:34   ` Christoph Hellwig
2020-04-22  2:07 ` [PATCH 17/19] xfs: hoist the ail unlock/lock cycle when cancelling intents during recovery Darrick J. Wong
2020-04-25 18:35   ` Christoph Hellwig
2020-04-22  2:07 ` [PATCH 18/19] xfs: remove xlog_item_is_intent Darrick J. Wong
2020-04-22  2:08 ` [PATCH 19/19] xfs: move xlog_recover_intent_pass2 up in the file Darrick J. Wong
2020-04-25 18:36   ` Christoph Hellwig
2020-04-28 22:38     ` Darrick J. Wong
2020-04-22 16:18 ` [PATCH 00/19] xfs: refactor log recovery Brian Foster
2020-04-28  6:12   ` Christoph Hellwig
2020-04-28 12:43     ` Brian Foster
2020-04-28 22:34       ` Darrick J. Wong
2020-04-29  6:09         ` Christoph Hellwig
2020-04-29 11:52         ` Brian Foster
2020-04-29 14:22           ` Darrick J. Wong
2020-04-28  6:22 ` Christoph Hellwig
2020-04-28 22:28   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=158752122672.2140829.3691203963610665663.stgit@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.