Re: [PULL 00/20] first set of s390x patches for 5.1 - no-reply

From: no-reply@patchew.org
To: cohuck@redhat.com
Cc: peter.maydell@linaro.org, qemu-s390x@nongnu.org,
	cohuck@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PULL 00/20] first set of s390x patches for 5.1
Date: Thu, 30 Apr 2020 08:36:52 -0700 (PDT)	[thread overview]
Message-ID: <158826101162.4471.10050692361584574228@45ef0f9c86ae> (raw)
In-Reply-To: <20200430094445.25943-1-cohuck@redhat.com>

Patchew URL: https://patchew.org/QEMU/20200430094445.25943-1-cohuck@redhat.com/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200430094445.25943-1-cohuck@redhat.com
Subject: [PULL 00/20] first set of s390x patches for 5.1
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200324150847.10476-1-frankja@linux.ibm.com -> patchew/20200324150847.10476-1-frankja@linux.ibm.com
Switched to a new branch 'test'
fcabb6a s390x/s390-virtio-ccw: Fix build on systems without KVM
fd13ac1 s390x/pv: Retry ioctls on -EINTR
c98fe29 s390x: protvirt: Fix stray error_report_err in s390_machine_protect
c221e09 s390x: Add unpack facility feature to GA1
a08dd76 docs: system: Add protvirt docs
ff79a2c s390x: protvirt: Handle SIGP store status correctly
223c784 s390x: protvirt: Move IO control structures over SIDA
1036819 s390x: protvirt: Disable address checks for PV guest IO emulation
56b7451 s390x: protvirt: Move diag 308 data over SIDA
921b401 s390x: protvirt: Set guest IPL PSW
09f7d8a s390x: protvirt: SCLP interpretation
b258176 s390x: protvirt: Move STSI data over SIDAD
f62b039 s390x: Add SIDA memory ops
27f9d55 s390x: protvirt: KVM intercept changes
de0120f s390x: protvirt: Inhibit balloon when switching to protected mode
d45de19 s390x: protvirt: Add migration blocker
55e8570 s390x: protvirt: Support unpack facility
9f447eb s390x: Move diagnose 308 subcodes and rcs into ipl.h
2e32370 linux-headers: update against Linux 5.7-rc3
6f22a18 virtio-net: fix rsc_ext compat handling

=== OUTPUT BEGIN ===
1/20 Checking commit 6f22a18993ff (virtio-net: fix rsc_ext compat handling)
2/20 Checking commit 2e3237041d8c (linux-headers: update against Linux 5.7-rc3)
3/20 Checking commit 9f447ebc050b (s390x: Move diagnose 308 subcodes and rcs into ipl.h)
4/20 Checking commit 55e85707c2f9 (s390x: protvirt: Support unpack facility)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#329: 
new file mode 100644

WARNING: line over 80 characters
#667: FILE: include/hw/s390x/pv.h:48:
+static inline int s390_pv_set_sec_parms(uint64_t origin, uint64_t length) { return 0; }

ERROR: line over 90 characters
#668: FILE: include/hw/s390x/pv.h:49:
+static inline int s390_pv_unpack(uint64_t addr, uint64_t size, uint64_t tweak) { return 0; }

WARNING: line over 80 characters
#768: FILE: target/s390x/diag.c:122:
+        valid = subcode == DIAG308_PV_SET ? iplb_valid_pv(iplb) : iplb_valid(iplb);

total: 1 errors, 3 warnings, 731 lines checked

Patch 4/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/20 Checking commit d45de195ff58 (s390x: protvirt: Add migration blocker)
6/20 Checking commit de0120fac9f4 (s390x: protvirt: Inhibit balloon when switching to protected mode)
7/20 Checking commit 27f9d55d1899 (s390x: protvirt: KVM intercept changes)
ERROR: switch and case should be at the same indent
#52: FILE: target/s390x/kvm.c:1701:
     switch (icpt_code) {
[...]
+        case ICPT_PV_INSTR:
+        case ICPT_PV_INSTR_NOTIFICATION:

total: 1 errors, 0 warnings, 16 lines checked

Patch 7/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/20 Checking commit f62b0396a473 (s390x: Add SIDA memory ops)
9/20 Checking commit b2581769e0fa (s390x: protvirt: Move STSI data over SIDAD)
10/20 Checking commit 09f7d8aaaba7 (s390x: protvirt: SCLP interpretation)
11/20 Checking commit 921b401113f5 (s390x: protvirt: Set guest IPL PSW)
12/20 Checking commit 56b7451c2868 (s390x: protvirt: Move diag 308 data over SIDA)
13/20 Checking commit 10368199a3be (s390x: protvirt: Disable address checks for PV guest IO emulation)
14/20 Checking commit 223c784848bc (s390x: protvirt: Move IO control structures over SIDA)
15/20 Checking commit ff79a2c3e199 (s390x: protvirt: Handle SIGP store status correctly)
16/20 Checking commit a08dd76e66a9 (docs: system: Add protvirt docs)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19: 
new file mode 100644

total: 0 errors, 1 warnings, 68 lines checked

Patch 16/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/20 Checking commit c221e093d122 (s390x: Add unpack facility feature to GA1)
18/20 Checking commit c98fe291725c (s390x: protvirt: Fix stray error_report_err in s390_machine_protect)
19/20 Checking commit fd13ac14980e (s390x/pv: Retry ioctls on -EINTR)
20/20 Checking commit fcabb6a0f6dd (s390x/s390-virtio-ccw: Fix build on systems without KVM)
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20200430094445.25943-1-cohuck@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com