Re: [PATCH 00/10] target/arm: Convert 2-reg-shift and 1-reg-imm Neon insns to decodetree - no-reply

From: no-reply@patchew.org
To: peter.maydell@linaro.org
Cc: qemu-arm@nongnu.org, richard.henderson@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 00/10] target/arm: Convert 2-reg-shift and 1-reg-imm Neon insns to decodetree
Date: Fri, 15 May 2020 14:32:57 -0700 (PDT)	[thread overview]
Message-ID: <158957837598.9380.8266522571100324097@45ef0f9c86ae> (raw)
In-Reply-To: <20200515142056.21346-1-peter.maydell@linaro.org>

Patchew URL: https://patchew.org/QEMU/20200515142056.21346-1-peter.maydell@linaro.org/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200515142056.21346-1-peter.maydell@linaro.org
Subject: [PATCH 00/10] target/arm: Convert 2-reg-shift and 1-reg-imm Neon insns to decodetree
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
74c8ea0 target/arm: Convert Neon one-register-and-immediate insns to decodetree
7dc1693 target/arm: Convert VCVT fixed-point ops to decodetree
dc02d37 target/arm: Convert Neon VSHLL, VMOVL to decodetree
7674a5e target/arm: Convert Neon narrowing shifts with op==9 to decodetree
6eed1f0 target/arm: Convert Neon narrowing shifts with op==8 to decodetree
b63364a target/arm: Convert VQSHLU, VQSHL 2-reg-shift insns to decodetree
1e6fb4a target/arm: Convert Neon VSRA, VSRI, VRSHR, VRSRA 2-reg-shift insns to decodetree
735501e target/arm: Convert Neon VSHR 2-reg-shift insns to decodetree
95697c1 target/arm: Convert Neon VSHL and VSLI 2-reg-shift insn to decodetree
ecf2d95 target/arm: Remove unused GEN_NEON_INTEGER_OP macro

=== OUTPUT BEGIN ===
1/10 Checking commit ecf2d95da0c2 (target/arm: Remove unused GEN_NEON_INTEGER_OP macro)
2/10 Checking commit 95697c1a03a3 (target/arm: Convert Neon VSHL and VSLI 2-reg-shift insn to decodetree)
ERROR: spaces required around that '*' (ctx:WxV)
#57: FILE: target/arm/translate-neon.inc.c:1314:
+static bool do_vector_2sh(DisasContext *s, arg_2reg_shift *a, GVecGen2iFn *fn)
                                                           ^

ERROR: spaces required around that '*' (ctx:WxV)
#87: FILE: target/arm/translate-neon.inc.c:1344:
+    static bool trans_##INSN##_2sh(DisasContext *s, arg_2reg_shift *a)  \
                                                                    ^

total: 2 errors, 0 warnings, 101 lines checked

Patch 2/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/10 Checking commit 735501ec3402 (target/arm: Convert Neon VSHR 2-reg-shift insns to decodetree)
ERROR: spaces required around that '*' (ctx:WxV)
#84: FILE: target/arm/translate-neon.inc.c:1370:
+static bool trans_VSHR_S_2sh(DisasContext *s, arg_2reg_shift *a)
                                                              ^

total: 1 errors, 0 warnings, 113 lines checked

Patch 3/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/10 Checking commit 1e6fb4a901be (target/arm: Convert Neon VSRA, VSRI, VRSHR, VRSRA 2-reg-shift insns to decodetree)
5/10 Checking commit b63364afac7a (target/arm: Convert VQSHLU, VQSHL 2-reg-shift insns to decodetree)
6/10 Checking commit 6eed1f014a7c (target/arm: Convert Neon narrowing shifts with op==8 to decodetree)
ERROR: do not use C99 // comments
#175: FILE: target/arm/translate-neon.inc.c:1611:
+    // todo expand out the shift-narrow and the narrow-op

total: 1 errors, 0 warnings, 219 lines checked

Patch 6/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/10 Checking commit 7674a5e418f9 (target/arm: Convert Neon narrowing shifts with op==9 to decodetree)
8/10 Checking commit dc02d373d232 (target/arm: Convert Neon VSHLL, VMOVL to decodetree)
9/10 Checking commit 7dc1693ad7a8 (target/arm: Convert VCVT fixed-point ops to decodetree)
10/10 Checking commit 74c8ea05ee0f (target/arm: Convert Neon one-register-and-immediate insns to decodetree)
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20200515142056.21346-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com