Re: [PATCH v6 00/16] acpi: i386 tweaks - no-reply

From: no-reply@patchew.org
To: kraxel@redhat.com
Cc: lvivier@redhat.com, kwolf@redhat.com, thuth@redhat.com,
	ehabkost@redhat.com, qemu-block@nongnu.org, mst@redhat.com,
	qemu-devel@nongnu.org, mreitz@redhat.com,
	marcandre.lureau@redhat.com, kraxel@redhat.com,
	pbonzini@redhat.com, imammedo@redhat.com, jsnow@redhat.com,
	rth@twiddle.net
Subject: Re: [PATCH v6 00/16] acpi: i386 tweaks
Date: Sat, 16 May 2020 01:29:24 -0700 (PDT)	[thread overview]
Message-ID: <158961776278.15373.15563171252292830868@45ef0f9c86ae> (raw)
In-Reply-To: <20200515150421.25479-1-kraxel@redhat.com>

Patchew URL: https://patchew.org/QEMU/20200515150421.25479-1-kraxel@redhat.com/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200515150421.25479-1-kraxel@redhat.com
Subject: [PATCH v6 00/16] acpi: i386 tweaks
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
69ff2b9 acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.
0e608e1 acpi: drop build_piix4_pm()
79bb41f acpi: drop serial/parallel enable bits from dsdt
3d483e1 acpi: simplify build_isa_devices_aml()
c9db35e acpi: factor out fw_cfg_add_acpi_dsdt()
4d0c5ba acpi: move aml builder code for i8042 (kbd+mouse) device
db9a5fa floppy: move cmos_get_fd_drive_type() from pc
3d99a4d floppy: make isa_fdc_get_drive_max_chs static
50ec383 acpi: move aml builder code for floppy device
ca585c0 acpi: move aml builder code for parallel device
db438d0 acpi: parallel: don't use _STA method
6a5550d acpi: move aml builder code for serial device
585d308 acpi: serial: don't use _STA method
6390dcb acpi: rtc: use a single crs range
730eda7 acpi: move aml builder code for rtc device
0f58dfa qtest: allow DSDT acpi table changes

=== OUTPUT BEGIN ===
1/16 Checking commit 0f58dfaf03d2 (qtest: allow DSDT acpi table changes)
2/16 Checking commit 730eda75f32f (acpi: move aml builder code for rtc device)
3/16 Checking commit 6390dcbc7606 (acpi: rtc: use a single crs range)
4/16 Checking commit 585d308b5a73 (acpi: serial: don't use _STA method)
5/16 Checking commit 6a5550d61069 (acpi: move aml builder code for serial device)
6/16 Checking commit db438d094684 (acpi: parallel: don't use _STA method)
7/16 Checking commit ca585c07c338 (acpi: move aml builder code for parallel device)
8/16 Checking commit 50ec383087f1 (acpi: move aml builder code for floppy device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#245: 
new file mode 100644

total: 0 errors, 1 warnings, 221 lines checked

Patch 8/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/16 Checking commit 3d99a4dae716 (floppy: make isa_fdc_get_drive_max_chs static)
10/16 Checking commit db9a5fa00fa3 (floppy: move cmos_get_fd_drive_type() from pc)
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 82 lines checked

Patch 10/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/16 Checking commit 4d0c5bab6dae (acpi: move aml builder code for i8042 (kbd+mouse) device)
12/16 Checking commit c9db35eb2c73 (acpi: factor out fw_cfg_add_acpi_dsdt())
13/16 Checking commit 3d483e1810c7 (acpi: simplify build_isa_devices_aml())
14/16 Checking commit 79bb41f701f3 (acpi: drop serial/parallel enable bits from dsdt)
15/16 Checking commit 0e608e189800 (acpi: drop build_piix4_pm())
16/16 Checking commit 69ff2b91c86b (acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.)
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20200515150421.25479-1-kraxel@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com