Re: [PATCH v2 00/58] qdev: Rework how we plug into the parent bus - no-reply

From: no-reply@patchew.org
To: armbru@redhat.com
Cc: berrange@redhat.com, ehabkost@redhat.com, mst@redhat.com,
	alistair@alistair23.me, mark.cave-ayland@ilande.co.uk,
	qemu-devel@nongnu.org, kraxel@redhat.com, pbonzini@redhat.com,
	david@gibson.dropbear.id.au
Subject: Re: [PATCH v2 00/58] qdev: Rework how we plug into the parent bus
Date: Fri, 29 May 2020 23:15:01 -0700 (PDT)	[thread overview]
Message-ID: <159081929970.32479.15016869675108886622@45ef0f9c86ae> (raw)
In-Reply-To: <20200529134523.8477-1-armbru@redhat.com>

Patchew URL: https://patchew.org/QEMU/20200529134523.8477-1-armbru@redhat.com/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200529134523.8477-1-armbru@redhat.com
Subject: [PATCH v2 00/58] qdev: Rework how we plug into the parent bus
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200529134523.8477-1-armbru@redhat.com -> patchew/20200529134523.8477-1-armbru@redhat.com
Switched to a new branch 'test'
d7ba4cb MAINTAINERS: Make section QOM cover hw/core/*bus.c as well
e12f9a9 qdev: qdev_init_nofail() is now unused, drop
c587de1 qdev: Convert bus-less devices to qdev_realize() with Coccinelle
e3ec37d qdev: Use qdev_realize() in qdev_device_add()
508be87 qdev: Make qdev_realize() support bus-less devices
2b3a896 s390x/event-facility: Simplify creation of SCLP event devices
35263dc microbit: Eliminate two local variables in microbit_init()
bf24af3 sysbus: sysbus_init_child_obj() is now unused, drop
0f6c400 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4
eaeff13 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3
17b4e10 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2
e2a4e40 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1
452882c qdev: Drop qdev_realize() support for null bus
99093fa sysbus: Convert to sysbus_realize() etc. with Coccinelle
0a36513 sysbus: New sysbus_realize(), sysbus_realize_and_unref()
8004fce sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2
e347c20 hw/arm/armsse: Pass correct child size to sysbus_init_child_obj()
982e979 sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1
50a9e3b microbit: Tidy up sysbus_init_child_obj() @child argument
23fad3c sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls
d944eab macio: Eliminate macio_init_child_obj()
8bb71b7 macio: Convert use of qdev_set_parent_bus()
94f09a8 qom: Less verbose object_initialize_child()
248945e qom: Tidy up a few object_initialize_child() calls
71344e4 auxbus: Eliminate aux_create_slave()
cfce609 auxbus: Convert a use of qdev_set_parent_bus()
ffced2a auxbus: New aux_bus_realize(), pairing with aux_bus_init()
ad1d6ea auxbus: Rename aux_init_bus() to aux_bus_init()
4302b25 qdev: qdev_create(), qdev_try_create() are now unused, drop
b29fdb6 usb: Eliminate usb_try_create_simple()
044a4d6 usb: usb_create() is now unused, drop
2119f64 usb: Convert uses of usb_create()
0869d6b usb: New usb_new(), usb_realize_and_unref()
7a38216 ssi: ssi_create_slave_no_init() is now unused, drop
1de789b ssi: Convert last use of ssi_create_slave_no_init() manually
f0966db ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle
a44e783 ssi: ssi_auto_connect_slaves() never does anything, drop
dd97b52 isa: isa_create(), isa_try_create() are now unused, drop
facab3d isa: Convert uses of isa_create(), isa_try_create() manually
21c651e isa: Convert uses of isa_create() with Coccinelle
828f669 isa: New isa_new(), isa_realize_and_unref() etc.
7422b38 pci: pci_create(), pci_create_multifunction() are now unused, drop
d66dd66 pci: Convert uses of pci_create() etc. manually
47e9e7f pci: Convert uses of pci_create() etc. with Coccinelle
c2a7c32 hw/ppc: Eliminate two superfluous QOM casts
05dae68 pci: New pci_new(), pci_realize_and_unref() etc.
73a088d qdev: Convert uses of qdev_set_parent_bus() manually
a6a5708 qdev: Convert uses of qdev_set_parent_bus() with Coccinelle
04167e9 qdev: Convert uses of qdev_create() manually
3ddff84 qdev: Convert uses of qdev_create() with Coccinelle
3a0df8e qdev: Convert to qdev_unrealize() manually
b89c5d7 qdev: Convert to qdev_unrealize() with Coccinelle
5f39fa6 qdev: Convert to qbus_realize(), qbus_unrealize()
c056c1e qdev: Put qdev_new() to use with Coccinelle
8d85516 qdev: New qdev_new(), qdev_realize(), etc.
77a952f Revert "hw/versatile: realize the PCI root bus as part of the versatile init"
3e66cdd Revert "hw/prep: realize the PCI root bus as part of the prep init"
232f042 qdev: Rename qbus_realize() to qbus_init()

=== OUTPUT BEGIN ===
1/58 Checking commit 232f042d8722 (qdev: Rename qbus_realize() to qbus_init())
2/58 Checking commit 3e66cdd1d73c (Revert "hw/prep: realize the PCI root bus as part of the prep init")
3/58 Checking commit 77a952ffe9ae (Revert "hw/versatile: realize the PCI root bus as part of the versatile init")
4/58 Checking commit 8d855167bb6e (qdev: New qdev_new(), qdev_realize(), etc.)
5/58 Checking commit c056c1e1f85e (qdev: Put qdev_new() to use with Coccinelle)
6/58 Checking commit 5f39fa696d96 (qdev: Convert to qbus_realize(), qbus_unrealize())
7/58 Checking commit b89c5d7e3746 (qdev: Convert to qdev_unrealize() with Coccinelle)
8/58 Checking commit 3a0df8e4207e (qdev: Convert to qdev_unrealize() manually)
9/58 Checking commit 3ddff8499cd2 (qdev: Convert uses of qdev_create() with Coccinelle)
10/58 Checking commit 04167e9fc90b (qdev: Convert uses of qdev_create() manually)
11/58 Checking commit a6a57083d2bd (qdev: Convert uses of qdev_set_parent_bus() with Coccinelle)
12/58 Checking commit 73a088d875a8 (qdev: Convert uses of qdev_set_parent_bus() manually)
13/58 Checking commit 05dae681b4ba (pci: New pci_new(), pci_realize_and_unref() etc.)
14/58 Checking commit c2a7c3220d1c (hw/ppc: Eliminate two superfluous QOM casts)
15/58 Checking commit 47e9e7f0a084 (pci: Convert uses of pci_create() etc. with Coccinelle)
16/58 Checking commit d66dd66530c0 (pci: Convert uses of pci_create() etc. manually)
17/58 Checking commit 7422b38a58e9 (pci: pci_create(), pci_create_multifunction() are now unused, drop)
18/58 Checking commit 828f6693aeed (isa: New isa_new(), isa_realize_and_unref() etc.)
19/58 Checking commit 21c651efd456 (isa: Convert uses of isa_create() with Coccinelle)
ERROR: do not use C99 // comments
#384: FILE: hw/rtc/m48t59-isa.c:74:
+        ISADevice *isa_dev; // TODO move

ERROR: do not use C99 // comments
#420: FILE: hw/sparc64/sun4u.c:341:
+    ISADevice *isa_dev; // TODO move

total: 2 errors, 0 warnings, 348 lines checked

Patch 19/58 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/58 Checking commit facab3dfadfc (isa: Convert uses of isa_create(), isa_try_create() manually)
21/58 Checking commit dd97b525312d (isa: isa_create(), isa_try_create() are now unused, drop)
22/58 Checking commit a44e78379910 (ssi: ssi_auto_connect_slaves() never does anything, drop)
23/58 Checking commit f0966dbe62a4 (ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle)
24/58 Checking commit 1de789b60d8a (ssi: Convert last use of ssi_create_slave_no_init() manually)
25/58 Checking commit 7a38216fb33c (ssi: ssi_create_slave_no_init() is now unused, drop)
26/58 Checking commit 0869d6ba1a73 (usb: New usb_new(), usb_realize_and_unref())
27/58 Checking commit 2119f64c2ca3 (usb: Convert uses of usb_create())
28/58 Checking commit 044a4d6cba59 (usb: usb_create() is now unused, drop)
29/58 Checking commit b29fdb68432b (usb: Eliminate usb_try_create_simple())
30/58 Checking commit 4302b25bd6b4 (qdev: qdev_create(), qdev_try_create() are now unused, drop)
31/58 Checking commit ad1d6ea181fc (auxbus: Rename aux_init_bus() to aux_bus_init())
32/58 Checking commit ffced2a78cb6 (auxbus: New aux_bus_realize(), pairing with aux_bus_init())
33/58 Checking commit cfce60963ab9 (auxbus: Convert a use of qdev_set_parent_bus())
34/58 Checking commit 71344e4c5afe (auxbus: Eliminate aux_create_slave())
35/58 Checking commit 248945e450af (qom: Tidy up a few object_initialize_child() calls)
36/58 Checking commit 94f09a87da15 (qom: Less verbose object_initialize_child())
37/58 Checking commit 8bb71b7a9fcd (macio: Convert use of qdev_set_parent_bus())
38/58 Checking commit d944eab8a07b (macio: Eliminate macio_init_child_obj())
39/58 Checking commit 23fad3cc341b (sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls)
WARNING: line over 80 characters
#144: FILE: hw/arm/aspeed_ast2600.c:221:
+                          &s->emmc.slots[0], sizeof(s->emmc.slots[0]), TYPE_SYSBUS_SDHCI);

total: 0 errors, 1 warnings, 238 lines checked

Patch 39/58 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/58 Checking commit 50a9e3b3366d (microbit: Tidy up sysbus_init_child_obj() @child argument)
41/58 Checking commit 982e9790fd59 (sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1)
42/58 Checking commit e347c204888d (hw/arm/armsse: Pass correct child size to sysbus_init_child_obj())
43/58 Checking commit 8004fcea39f3 (sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2)
44/58 Checking commit 0a365131a1e3 (sysbus: New sysbus_realize(), sysbus_realize_and_unref())
45/58 Checking commit 99093fa93c79 (sysbus: Convert to sysbus_realize() etc. with Coccinelle)
46/58 Checking commit 452882cdb7f1 (qdev: Drop qdev_realize() support for null bus)
47/58 Checking commit e2a4e40c0531 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1)
48/58 Checking commit 17b4e1066a39 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2)
49/58 Checking commit eaeff1393910 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3)
50/58 Checking commit 0f6c4002d974 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4)
51/58 Checking commit bf24af33dc68 (sysbus: sysbus_init_child_obj() is now unused, drop)
52/58 Checking commit 35263dc00779 (microbit: Eliminate two local variables in microbit_init())
53/58 Checking commit 2b3a89646588 (s390x/event-facility: Simplify creation of SCLP event devices)
54/58 Checking commit 508be87c6a2a (qdev: Make qdev_realize() support bus-less devices)
55/58 Checking commit e3ec37da1165 (qdev: Use qdev_realize() in qdev_device_add())
56/58 Checking commit c587de1554de (qdev: Convert bus-less devices to qdev_realize() with Coccinelle)
57/58 Checking commit e12f9a955afa (qdev: qdev_init_nofail() is now unused, drop)
58/58 Checking commit d7ba4cbc8d3d (MAINTAINERS: Make section QOM cover hw/core/*bus.c as well)
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20200529134523.8477-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com