From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Chris Wilson" <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/23] drm/i915: Drop vm.ref for duplicate vma on construction
Date: Thu, 02 Jul 2020 09:17:37 -0000 [thread overview]
Message-ID: <159368145746.5656.373487303433587725@emeril.freedesktop.org> (raw)
In-Reply-To: <20200702083225.20044-1-chris@chris-wilson.co.uk>
== Series Details ==
Series: series starting with [01/23] drm/i915: Drop vm.ref for duplicate vma on construction
URL : https://patchwork.freedesktop.org/series/79037/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2b716a4a1108 drm/i915: Drop vm.ref for duplicate vma on construction
02e97324e6dd drm/i915/gem: Split the context's obj:vma lut into its own mutex
-:82: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#82: FILE: drivers/gpu/drm/i915/gem/i915_gem_context_types.h:173:
+ struct mutex lut_mutex;
total: 0 errors, 0 warnings, 1 checks, 105 lines checked
981b52482265 drm/i915/gem: Drop forced struct_mutex from shrinker_taints_mutex
63cac79e5aff drm/i915/gem: Only revoke mmap handlers if active
ceb2d68f55a0 drm/i915: Export ppgtt_bind_vma
41eb0c64c9b6 drm/i915: Preallocate stashes for vma page-directories
84369a1c6dad drm/i915: Switch to object allocations for page directories
880e4a90f882 drm/i915/gem: Don't drop the timeline lock during execbuf
84600d1a1d00 drm/i915/gem: Rename execbuf.bind_link to unbound_link
6ce1d70bdaa0 drm/i915/gem: Break apart the early i915_vma_pin from execbuf object lookup
6095d5335d88 drm/i915/gem: Remove the call for no-evict i915_vma_pin
8041afeb3c3a drm/i915: Add list_for_each_entry_safe_continue_reverse
-:21: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pos' - possible side-effects?
#21: FILE: drivers/gpu/drm/i915/i915_utils.h:269:
+#define list_for_each_entry_safe_continue_reverse(pos, n, head, member) \
+ for (pos = list_prev_entry(pos, member), \
+ n = list_prev_entry(pos, member); \
+ &pos->member != (head); \
+ pos = n, n = list_prev_entry(n, member))
-:21: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects?
#21: FILE: drivers/gpu/drm/i915/i915_utils.h:269:
+#define list_for_each_entry_safe_continue_reverse(pos, n, head, member) \
+ for (pos = list_prev_entry(pos, member), \
+ n = list_prev_entry(pos, member); \
+ &pos->member != (head); \
+ pos = n, n = list_prev_entry(n, member))
-:21: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible side-effects?
#21: FILE: drivers/gpu/drm/i915/i915_utils.h:269:
+#define list_for_each_entry_safe_continue_reverse(pos, n, head, member) \
+ for (pos = list_prev_entry(pos, member), \
+ n = list_prev_entry(pos, member); \
+ &pos->member != (head); \
+ pos = n, n = list_prev_entry(n, member))
total: 0 errors, 0 warnings, 3 checks, 12 lines checked
5f2ba176cfcc drm/i915: Always defer fenced work to the worker
3bc8dcef47f8 drm/i915/gem: Assign context id for async work
658265850918 drm/i915: Export a preallocate variant of i915_active_acquire()
3474748efc48 drm/i915/gem: Separate the ww_mutex walker into its own list
9596fd217b0e drm/i915/gem: Asynchronous GTT unbinding
11531ee318da drm/i915/gem: Bind the fence async for execbuf
67d8c52b893a drm/i915/gem: Include cmdparser in common execbuf pinning
c9ad9f9d60dd drm/i915/gem: Include secure batch in common execbuf pinning
db49ec7ea2ce drm/i915/gem: Reintroduce multiple passes for reloc processing
-:993: WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#993: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_execbuffer.c:14:
+#if 0
-:1006: WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#1006: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_execbuffer.c:27:
+#if 0
total: 0 errors, 2 warnings, 0 checks, 969 lines checked
1375d1da0182 drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.
-:78: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#78:
new file mode 100644
-:151: WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#151: FILE: drivers/gpu/drm/i915/mm/i915_acquire_ctx.c:69:
+#if 0
total: 0 errors, 2 warnings, 0 checks, 187 lines checked
6f377648e7f5 drm/i915/gem: Pull execbuf dma resv under a single critical section
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-07-02 9:17 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 8:32 [PATCH 01/23] drm/i915: Drop vm.ref for duplicate vma on construction Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] " Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] [PATCH 02/23] drm/i915/gem: Split the context's obj:vma lut into its own mutex Chris Wilson
2020-07-02 22:09 ` Andi Shyti
2020-07-02 22:14 ` Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] [PATCH 03/23] drm/i915/gem: Drop forced struct_mutex from shrinker_taints_mutex Chris Wilson
2020-07-02 22:24 ` Andi Shyti
2020-07-02 8:32 ` [Intel-gfx] [PATCH 04/23] drm/i915/gem: Only revoke mmap handlers if active Chris Wilson
2020-07-02 12:35 ` Tvrtko Ursulin
2020-07-02 12:47 ` Chris Wilson
2020-07-02 12:54 ` Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] [PATCH 05/23] drm/i915: Export ppgtt_bind_vma Chris Wilson
2020-07-03 10:09 ` Andi Shyti
2020-07-02 8:32 ` [Intel-gfx] [PATCH 06/23] drm/i915: Preallocate stashes for vma page-directories Chris Wilson
2020-07-03 16:47 ` Tvrtko Ursulin
2020-07-02 8:32 ` [Intel-gfx] [PATCH 07/23] drm/i915: Switch to object allocations for page directories Chris Wilson
2020-07-03 8:44 ` Tvrtko Ursulin
2020-07-03 9:00 ` Chris Wilson
2020-07-03 9:24 ` Tvrtko Ursulin
2020-07-03 9:49 ` Chris Wilson
2020-07-03 16:34 ` Tvrtko Ursulin
2020-07-03 16:36 ` Tvrtko Ursulin
2020-07-02 8:32 ` [Intel-gfx] [PATCH 08/23] drm/i915/gem: Don't drop the timeline lock during execbuf Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] [PATCH 09/23] drm/i915/gem: Rename execbuf.bind_link to unbound_link Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] [PATCH 10/23] drm/i915/gem: Break apart the early i915_vma_pin from execbuf object lookup Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] [PATCH 11/23] drm/i915/gem: Remove the call for no-evict i915_vma_pin Chris Wilson
2020-07-03 8:59 ` Tvrtko Ursulin
2020-07-03 9:23 ` Chris Wilson
2020-07-06 14:43 ` Tvrtko Ursulin
2020-07-02 8:32 ` [Intel-gfx] [PATCH 12/23] drm/i915: Add list_for_each_entry_safe_continue_reverse Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] [PATCH 13/23] drm/i915: Always defer fenced work to the worker Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] [PATCH 14/23] drm/i915/gem: Assign context id for async work Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] [PATCH 15/23] drm/i915: Export a preallocate variant of i915_active_acquire() Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] [PATCH 16/23] drm/i915/gem: Separate the ww_mutex walker into its own list Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] [PATCH 17/23] drm/i915/gem: Asynchronous GTT unbinding Chris Wilson
2020-07-05 22:01 ` Andi Shyti
2020-07-05 22:07 ` Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] [PATCH 18/23] drm/i915/gem: Bind the fence async for execbuf Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] [PATCH 19/23] drm/i915/gem: Include cmdparser in common execbuf pinning Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] [PATCH 20/23] drm/i915/gem: Include secure batch " Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] [PATCH 21/23] drm/i915/gem: Reintroduce multiple passes for reloc processing Chris Wilson
2020-07-02 8:32 ` [Intel-gfx] [PATCH 22/23] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2 Chris Wilson
2020-07-02 22:32 ` kernel test robot
2020-07-02 8:32 ` [Intel-gfx] [PATCH 23/23] drm/i915/gem: Pull execbuf dma resv under a single critical section Chris Wilson
2020-07-02 9:17 ` Patchwork [this message]
2020-07-02 9:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/23] drm/i915: Drop vm.ref for duplicate vma on construction Patchwork
2020-07-02 9:40 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-07-02 12:27 ` [Intel-gfx] [PATCH 01/23] " Tvrtko Ursulin
2020-07-02 12:27 ` Tvrtko Ursulin
2020-07-02 13:08 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/23] " Patchwork
2020-07-02 20:25 ` [Intel-gfx] [PATCH 01/23] " Andi Shyti
2020-07-02 20:25 ` Andi Shyti
2020-07-02 20:38 ` Chris Wilson
2020-07-02 20:38 ` Chris Wilson
2020-07-02 20:56 ` Andi Shyti
2020-07-02 20:56 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159368145746.5656.373487303433587725@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.