Re: [PATCH v4 00/21] microvm: add acpi support - no-reply

From: no-reply@patchew.org
To: kraxel@redhat.com
Cc: lvivier@redhat.com, peter.maydell@linaro.org, thuth@redhat.com,
	ehabkost@redhat.com, slp@redhat.com, mst@redhat.com,
	qemu-devel@nongnu.org, shannon.zhaosl@gmail.com,
	qemu-arm@nongnu.org, kraxel@redhat.com, imammedo@redhat.com,
	pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [PATCH v4 00/21] microvm: add acpi support
Date: Thu, 2 Jul 2020 14:23:44 -0700 (PDT)	[thread overview]
Message-ID: <159372502227.6600.14343668785745077739@d1fd068a5071> (raw)
In-Reply-To: <20200702204859.9876-1-kraxel@redhat.com>

Patchew URL: https://patchew.org/QEMU/20200702204859.9876-1-kraxel@redhat.com/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v4 00/21] microvm: add acpi support
Type: series
Message-id: 20200702204859.9876-1-kraxel@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200702204859.9876-1-kraxel@redhat.com -> patchew/20200702204859.9876-1-kraxel@redhat.com
Switched to a new branch 'test'
1e173ac tests/acpi: update expected data files for microvm
7f4d75c tests/acpi: add microvm test
7933c7d tests/acpi: allow override blkdev
8246d8e tests/acpi: allow microvm test data updates.
09ff54c tests/acpi: clear bios-tables-test-allowed-diff.h
a6ac3a9 microvm: wire up hotplug
37fe132 x86: move cpu plug from pc to x86
18502ab x86: move acpi_dev from pc/microvm
e25eb4c x86: constify x86_machine_is_*_enabled
3144c4e microvm/acpi: disable virtio-mmio cmdline hack
488512b microvm/acpi: use seabios with acpi=on
4dce0b0 microvm/acpi: use GSI 16-23 for virtio
6c1e43a microvm/acpi: add acpi_dsdt_add_virtio() for x86
7e90f10 microvm/acpi: add minimal acpi support
91fb357 microvm: make virtio irq base runtime configurable
75d0e28 acpi: move acpi_dsdt_add_power_button() to ged
b1b3872 acpi: ged: add x86 device variant.
2f82b96 acpi: ged: add control regs
7b24784 seabios: add bios-microvm.bin binary
be06767 seabios: add microvm config, update build rules
30aa71d microvm: name qboot binary qboot.rom

=== OUTPUT BEGIN ===
1/21 Checking commit 30aa71d445e7 (microvm: name qboot binary qboot.rom)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
rename from pc-bios/bios-microvm.bin

total: 0 errors, 1 warnings, 35 lines checked

Patch 1/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/21 Checking commit be0676767e5e (seabios: add microvm config, update build rules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 39 lines checked

Patch 2/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/21 Checking commit 7b247849b125 (seabios: add bios-microvm.bin binary)
4/21 Checking commit 2f82b96fc4fb (acpi: ged: add control regs)
5/21 Checking commit b1b387286c9d (acpi: ged: add x86 device variant.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
new file mode 100644

total: 0 errors, 1 warnings, 51 lines checked

Patch 5/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/21 Checking commit 75d0e28f4afe (acpi: move acpi_dsdt_add_power_button() to ged)
7/21 Checking commit 91fb3578211e (microvm: make virtio irq base runtime configurable)
8/21 Checking commit 7e90f10773b4 (microvm/acpi: add minimal acpi support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#39: FILE: hw/i386/acpi-microvm.c:1:
+/* Support for generating ACPI tables and passing them to Guests

WARNING: Block comments use a leading /* on a separate line
#150: FILE: hw/i386/acpi-microvm.c:112:
+    table_offsets = g_array_new(false, true /* clear */,

WARNING: Block comments use a leading /* on a separate line
#154: FILE: hw/i386/acpi-microvm.c:116:
+                             64 /* Ensure FACS is aligned */,

WARNING: Block comments use a leading /* on a separate line
#155: FILE: hw/i386/acpi-microvm.c:117:
+                             false /* high memory */);

total: 0 errors, 5 warnings, 297 lines checked

Patch 8/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/21 Checking commit 6c1e43a0b904 (microvm/acpi: add acpi_dsdt_add_virtio() for x86)
10/21 Checking commit 4dce0b04d88f (microvm/acpi: use GSI 16-23 for virtio)
11/21 Checking commit 488512b60cfb (microvm/acpi: use seabios with acpi=on)
12/21 Checking commit 3144c4ef8a34 (microvm/acpi: disable virtio-mmio cmdline hack)
13/21 Checking commit e25eb4c6c1ca (x86: constify x86_machine_is_*_enabled)
14/21 Checking commit 18502ab064f4 (x86: move acpi_dev from pc/microvm)
15/21 Checking commit 37fe132c446b (x86: move cpu plug from pc to x86)
ERROR: space required before the open parenthesis '('
#344: FILE: hw/i386/x86.c:187:
+    if(!object_dynamic_cast(OBJECT(cpu), ms->cpu_type)) {

WARNING: Block comments use a leading /* on a separate line
#431: FILE: hw/i386/x86.c:274:
+    /* if 'address' properties socket-id/core-id/thread-id are not set, set them

WARNING: Block comments use a leading /* on a separate line
#434: FILE: hw/i386/x86.c:277:
+    /* TODO: move socket_id/core_id/thread_id checks into x86_cpu_realizefn()

WARNING: Block comments use a trailing */ on a separate line
#436: FILE: hw/i386/x86.c:279:
+     * CPUState::nr_cores and CPUState::nr_threads fields instead of globals */

WARNING: Block comments use a leading /* on a separate line
#484: FILE: hw/i386/x86.c:327:
+        /* If the number of CPUs can't be represented in 8 bits, the

WARNING: Block comments use a leading /* on a separate line
#502: FILE: hw/i386/x86.c:345:
+/* returns pointer to CPUArchId descriptor that matches CPU's apic_id

total: 1 errors, 5 warnings, 533 lines checked

Patch 15/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

16/21 Checking commit a6ac3a966c0d (microvm: wire up hotplug)
17/21 Checking commit 09ff54c06666 (tests/acpi: clear bios-tables-test-allowed-diff.h)
18/21 Checking commit 8246d8e472f7 (tests/acpi: allow microvm test data updates.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 4 lines checked

Patch 18/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/21 Checking commit 7933c7d34c9f (tests/acpi: allow override blkdev)
20/21 Checking commit 7f4d75c92df2 (tests/acpi: add microvm test)
21/21 Checking commit 1e173acb1faa (tests/acpi: update expected data files for microvm)
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20200702204859.9876-1-kraxel@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com