From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: [PATCH v3 6/8] irqchip/loongson-pch-msi: Remove unneeded variable
Date: Tue, 7 Jul 2020 10:12:50 +0800 [thread overview]
Message-ID: <1594087972-21715-7-git-send-email-yangtiezhu@loongson.cn> (raw)
In-Reply-To: <1594087972-21715-1-git-send-email-yangtiezhu@loongson.cn>
irq_domain_alloc_irqs_parent() returns 0 on success and non-zero value
on failure, it is redudant to check its non-zero return value and then
return it, so just remove the variable "ret" and return directly in the
function pch_msi_parent_domain_alloc().
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/irqchip/irq-loongson-pch-msi.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/irqchip/irq-loongson-pch-msi.c b/drivers/irqchip/irq-loongson-pch-msi.c
index 50becd2..12aeeab 100644
--- a/drivers/irqchip/irq-loongson-pch-msi.c
+++ b/drivers/irqchip/irq-loongson-pch-msi.c
@@ -100,17 +100,12 @@ static int pch_msi_parent_domain_alloc(struct irq_domain *domain,
unsigned int virq, int hwirq)
{
struct irq_fwspec fwspec;
- int ret;
fwspec.fwnode = domain->parent->fwnode;
fwspec.param_count = 1;
fwspec.param[0] = hwirq;
- ret = irq_domain_alloc_irqs_parent(domain, virq, 1, &fwspec);
- if (ret)
- return ret;
-
- return 0;
+ return irq_domain_alloc_irqs_parent(domain, virq, 1, &fwspec);
}
static int pch_msi_middle_domain_alloc(struct irq_domain *domain,
--
2.1.0
next prev parent reply other threads:[~2020-07-07 2:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 2:12 [PATCH v3 0/8] irqchip: Fix some issues and do some code cleanups about Loongson Tiezhu Yang
2020-07-07 2:12 ` [PATCH v3 1/8] irqchip/loongson-htpic: Remove redundant kfree operation Tiezhu Yang
2020-07-07 2:12 ` [PATCH v3 2/8] irqchip/loongson-htpic: Remove unneeded select of I8259 Tiezhu Yang
2020-07-07 2:12 ` [PATCH v3 3/8] irqchip/loongson-htvec: Fix potential resource leak Tiezhu Yang
2020-07-07 2:12 ` [PATCH v3 4/8] irqchip/loongson-htvec: Check return value of irq_domain_translate_onecell() Tiezhu Yang
2020-07-07 2:12 ` [PATCH v3 5/8] irqchip/loongson-pch-pic: Check return value of irq_domain_translate_twocell() Tiezhu Yang
2020-07-07 2:12 ` Tiezhu Yang [this message]
2020-07-07 2:12 ` [PATCH v3 7/8] irqchip/loongson-liointc: Fix potential dead lock Tiezhu Yang
2020-07-07 2:12 ` [PATCH v3 8/8] dt-bindings: interrupt-controller: Fix typos in loongson,liointc.yaml Tiezhu Yang
2020-07-13 21:41 ` Rob Herring
2020-07-14 1:39 ` Tiezhu Yang
2020-07-17 12:48 ` [PATCH v3 0/8] irqchip: Fix some issues and do some code cleanups about Loongson Marc Zyngier
2020-07-17 12:48 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594087972-21715-7-git-send-email-yangtiezhu@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=jason@lakedaemon.net \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.