From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/3] btrfs-progs: convert: better ENOSPC handling
Date: Sat, 1 Aug 2020 07:37:13 +0800 [thread overview]
Message-ID: <15958814-4956-12bd-3297-0ce3bc495a87@gmx.com> (raw)
In-Reply-To: <20200731161634.GP3703@twin.jikos.cz>
[-- Attachment #1.1: Type: text/plain, Size: 1506 bytes --]
On 2020/8/1 上午12:16, David Sterba wrote:
> On Wed, Jul 29, 2020 at 04:40:35PM +0800, Qu Wenruo wrote:
>> This patchset is to address a bug report [1], where even with the bit
>> overflow bug fixed, the user is still unable to convert an ext4 fs to
>> btrfs.
>>
>> The error is -ENOSPC, which triggers BUG_ON() and brings the end to the
>> convertion.
>>
>> We're still waiting for the image dump to determine what's the real
>> cause is, but considering the user is still reporting around 40% free
>> space, I guess it's something wrong with the extent allocator.
>>
>> But still, we can enhance btrfs-convert to make it handle errors more
>> gracefully, with better error message, and even some debugging info like
>> the available space / total space ratio.
>>
>> Qu Wenruo (3):
>> btrfs-progs: convert: handle errors better in ext2_copy_inodes()
>> btrfs-progs: convert: update error message to reflect original fs
>> unmodified cases
>> btrfs-progs: convert: report available space before convertion happens
>
> Added to devel, thanks. With the fixup and I've updated the space report
> to look like this:
>
> create btrfs filesystem:
> blocksize: 4096
> nodesize: 16384
> features: extref, skinny-metadata (default)
> checksum: crc32c
> free space report:
> total: 2147483648
> free: 1610547200 (75.00%)
>
Wow, that looks even better!
Thanks for the hot fix and enhanced UI!
Qu
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-07-31 23:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 8:40 [PATCH 0/3] btrfs-progs: convert: better ENOSPC handling Qu Wenruo
2020-07-29 8:40 ` [PATCH 1/3] btrfs-progs: convert: handle errors better in ext2_copy_inodes() Qu Wenruo
2020-07-29 8:40 ` [PATCH 2/3] btrfs-progs: convert: update error message to reflect original fs unmodified cases Qu Wenruo
2020-07-29 8:40 ` [PATCH 3/3] btrfs-progs: convert: report available space before convertion happens Qu Wenruo
2020-07-29 9:05 ` Su Yue
2020-07-29 9:13 ` Qu Wenruo
2020-07-31 15:35 ` David Sterba
2020-07-31 16:16 ` [PATCH 0/3] btrfs-progs: convert: better ENOSPC handling David Sterba
2020-07-31 23:37 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15958814-4956-12bd-3297-0ce3bc495a87@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.