From: Chuan Zheng <zhengchuan@huawei.com>
To: <quintela@redhat.com>, <eblake@redhat.com>, <dgilbert@redhat.com>,
<berrange@redhat.com>, <dme@dme.org>
Cc: alex.chen@huawei.com, ann.zhuangyanying@huawei.com,
zhang.zhanghailiang@huawei.com, xiexiangyou@huawei.com,
qemu-devel@nongnu.org
Subject: [PATCH v6 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE
Date: Sat, 29 Aug 2020 10:52:53 +0800 [thread overview]
Message-ID: <1598669577-76914-9-git-send-email-zhengchuan@huawei.com> (raw)
In-Reply-To: <1598669577-76914-1-git-send-email-zhengchuan@huawei.com>
In order to sample real RAM, skip ramblock with size below MIN_RAMBLOCK_SIZE
which is set as 128M.
Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
---
migration/dirtyrate.c | 19 +++++++++++++++++++
migration/dirtyrate.h | 5 +++++
2 files changed, 24 insertions(+)
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index 9cc2cbb..420fc59 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -164,6 +164,19 @@ alloc_ramblock_dirty_info(int *block_index,
return block_dinfo;
}
+static bool skip_sample_ramblock(RAMBlock *block)
+{
+ /*
+ * Consider ramblock with size larger than 128M is what we
+ * want to sample.
+ */
+ if (qemu_ram_get_used_length(block) < (MIN_RAMBLOCK_SIZE << 10)) {
+ return true;
+ }
+
+ return false;
+}
+
static int record_ramblock_hash_info(struct RamblockDirtyInfo **block_dinfo,
struct DirtyRateConfig config,
int *block_index)
@@ -174,6 +187,9 @@ static int record_ramblock_hash_info(struct RamblockDirtyInfo **block_dinfo,
int index = 0;
RAMBLOCK_FOREACH_MIGRATABLE(block) {
+ if (skip_sample_ramblock(block)) {
+ continue;
+ }
dinfo = alloc_ramblock_dirty_info(&index, dinfo);
if (dinfo == NULL) {
return -1;
@@ -241,6 +257,9 @@ static int compare_page_hash_info(struct RamblockDirtyInfo *info,
RAMBlock *block = NULL;
RAMBLOCK_FOREACH_MIGRATABLE(block) {
+ if (skip_sample_ramblock(block)) {
+ continue;
+ }
block_dinfo = find_page_matched(block, block_index + 1, info);
if (block_dinfo == NULL) {
continue;
diff --git a/migration/dirtyrate.h b/migration/dirtyrate.h
index a3ee305..faaf9da 100644
--- a/migration/dirtyrate.h
+++ b/migration/dirtyrate.h
@@ -24,6 +24,11 @@
*/
#define RAMBLOCK_INFO_MAX_LEN 256
+/*
+ * Minimum RAMBlock size to sample, in megabytes.
+ */
+#define MIN_RAMBLOCK_SIZE 128
+
struct DirtyRateConfig {
uint64_t sample_pages_per_gigabytes; /* sample pages per GB */
int64_t sample_period_seconds; /* time duration between two sampling */
--
1.8.3.1
next prev parent reply other threads:[~2020-08-29 2:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 2:52 [PATCH v6 00/12] *** A Method for evaluating dirty page rate *** Chuan Zheng
2020-08-29 2:52 ` [PATCH v6 01/12] migration/dirtyrate: setup up query-dirtyrate framwork Chuan Zheng
2020-08-31 8:54 ` David Edmondson
2020-08-31 11:07 ` Zheng Chuan
2020-08-29 2:52 ` [PATCH v6 02/12] migration/dirtyrate: add DirtyRateStatus to denote calculation status Chuan Zheng
2020-08-29 2:52 ` [PATCH v6 03/12] migration/dirtyrate: Add RamblockDirtyInfo to store sampled page info Chuan Zheng
2020-08-31 9:06 ` David Edmondson
2020-08-31 9:07 ` David Edmondson
2020-08-29 2:52 ` [PATCH v6 04/12] migration/dirtyrate: Add dirtyrate statistics series functions Chuan Zheng
2020-08-29 2:52 ` [PATCH v6 05/12] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h Chuan Zheng
2020-08-31 9:07 ` David Edmondson
2020-08-29 2:52 ` [PATCH v6 06/12] migration/dirtyrate: Record hash results for each sampled page Chuan Zheng
2020-08-31 9:08 ` David Edmondson
2020-08-29 2:52 ` [PATCH v6 07/12] migration/dirtyrate: Compare page hash results for recorded " Chuan Zheng
2020-08-31 9:10 ` David Edmondson
2020-08-31 11:10 ` Zheng Chuan
2020-08-29 2:52 ` Chuan Zheng [this message]
2020-08-31 9:12 ` [PATCH v6 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE David Edmondson
2020-08-29 2:52 ` [PATCH v6 09/12] migration/dirtyrate: Implement set_sample_page_period() and get_sample_page_period() Chuan Zheng
2020-08-31 9:12 ` David Edmondson
2020-08-29 2:52 ` [PATCH v6 10/12] migration/dirtyrate: Implement calculate_dirtyrate() function Chuan Zheng
2020-08-31 9:13 ` David Edmondson
2020-08-31 11:24 ` Zheng Chuan
2020-08-31 12:01 ` David Edmondson
2020-08-29 2:52 ` [PATCH v6 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function Chuan Zheng
2020-08-29 2:52 ` [PATCH v6 12/12] migration/dirtyrate: Add trace_calls to make it easier to debug Chuan Zheng
2020-08-31 9:14 ` David Edmondson
2020-08-31 9:05 ` [PATCH v6 00/12] *** A Method for evaluating dirty page rate *** David Edmondson
2020-08-31 9:55 ` Zheng Chuan
2020-08-31 10:08 ` David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1598669577-76914-9-git-send-email-zhengchuan@huawei.com \
--to=zhengchuan@huawei.com \
--cc=alex.chen@huawei.com \
--cc=ann.zhuangyanying@huawei.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dme@dme.org \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=xiexiangyou@huawei.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.